ci: drop the pnpm version pin from the publish job - #118
Merged
Merged
Conversation
The publish job checks out Etherpad core into the workspace, and core now
pins `packageManager: pnpm@12.4.2`. With `version: 10` also set on
pnpm/action-setup the action refuses to start:
Error: Multiple versions of pnpm specified:
- version 10 in the GitHub Action config with the key "version"
- version pnpm@12.4.2 in the package.json with the key "packageManager"
Dropping the input lets the action follow core's pin, which is what the
other ~75 plugin publish workflows already do.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
PR Summary by QodoRestore publishing by using Etherpad core's pnpm version
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing is blocked in this repo. The publish job checks out Etherpad core into the workspace, and core now pins
packageManager: pnpm@12.4.2. Because this workflow also setsversion: 10onpnpm/action-setup, the action refuses to start:Only this repo and one other still carry that input; the other ~75 plugin publish workflows have no
version:and follow core's pin. Dropping it here matches them.🤖 Generated with Claude Code
https://claude.ai/code/session_013S4pYSjwUsiZtdtMMpW7bw