pointers: allow regions named like object properties - #316
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dereferencethrewTypeError: Cannot redefine property: lengthwhen a pointer yielded a region namedlength. solc's ethdebug pointer templates (argotorg/solidity#16990) do this for a top-level dynamic array: the template yields regions namedlengthanditem. Inside a mapping it only worked because ayieldsrename turnslengthintovalue-length.The cause is in
cursor.view. It buildsregionsas an array-like and also defines each region name as a property of it, so a region namedlengthcollides with the array's ownlength. Names such asnamedandlookupwould collide the same way. The bookkeeping maps there, and theregionsandvariablesmaps used while generating regions, were plain objects, soconstructorortoStringresolved to inherited functions (named[name].push is not a function), and__proto__was never stored as a key.The maps now have no prototype, and the yields rename lookup checks own properties. A region whose name would shadow an existing property of
regionsis still reachable throughregions.lookupandregions.named, but is no longer also exposed as a property of the array. Names that do not collide keep working as before.Tests cover
length,constructor,__proto__andtoStringas region names, both referenced from a later region and renamed withyields.