Repository navigation
pointers: compose nested yields renames - #315
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When template references nest,
dereferencerenamed each yielded region using only the innermostyieldsmapping, so the enclosing references' renames were dropped. The spec says a reference'syieldsmaps the names its template produces, and an inner reference's renamed output is what the outer template produces, so renames should compose.This hit solc's ethdebug output (argotorg/solidity#16990): for
mapping(address => mapping(uint => Profile))whereProfilehas astring name, the string's data region came back asname-datainstead ofvalue-name-data.generateRegionsnow applies every mapping on the rename stack, innermost first, each renaming the previous result. Names saved for later references already composed, because each template'spop-region-renamesruns in turn from the inside out and aliases the previous result, so that path is unchanged. Behavior without nesting is unchanged. A regression test covers a two-level case, and the changelog has an entry.