Repository navigation
evm: execute with the prague hardfork so current solc output runs - #314
Merged
Merged
Conversation
The executor used shanghai, which rejects MCOPY, TLOAD and TSTORE as invalid opcodes. Current solc emits them by default.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ethdebug/evmconfigured its EVM with the Shanghai hardfork, so bytecode from current solc failed with an invalid opcode as soon as it hit MCOPY (0x5e). Transient storage (TLOAD/TSTORE) failed the same way. This surfaced when running real solc ethdebug output through the executor.The executor now uses Prague, named explicitly via
Hardfork.Pragueso behavior is reproducible and does not float with a "latest" default. Prague is the defaultevmVersionof recent solc releases, and the installed @ethereumjs 10.1 supports it. It is a superset of Cancun, so Cancun output runs too. The package takes no options today, so I changed the default only and did not add a configuration surface.Adds regression tests that run hand-assembled MCOPY and TSTORE/TLOAD snippets; both fail on the Shanghai setting. The existing suites, including bugc's, pass unchanged. Adds an entry to the package changelog.