ci: bump default ESP-IDF build version to v6.0.1 - #751
Merged
Conversation
All development has been on ESP-IDF v6 for a while, and the twai component (used by the twai/canopen examples) requires the v6.0 esp_driver_twai node API. Bump the build matrix default from v5.5.1 to v6.0.1 and keep an optional matrix.test.idf_version hook so a specific example can still pin a different IDF if it ever needs one. CI will surface any example that does not yet build on v6. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
✅Static analysis result - no issues found! ✅ |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, syntactically-correct workflow update that preserves per-matrix overrides, with only a minor follow-up doc-consistency nit noted.
Pull request overview
Updates the CI workflow so the ESP-IDF version used to build examples defaults to v6.0.1, while still allowing individual matrix entries to override the IDF version when needed.
Changes:
- Switch
esp_idf_versionfrom a fixedv5.5.1to a defaulted expression:${{ matrix.test.idf_version || 'v6.0.1' }}. - Add inline workflow comments documenting the new default and the per-matrix override mechanism.
File summaries
| File | Description |
|---|---|
| .github/workflows/build.yml | Changes the default ESP-IDF version used by the example-build CI step to v6.0.1 with an optional per-matrix override. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+346
to
+348
| # Default to ESP-IDF v6.0.1. Individual matrix entries can still pin a | ||
| # different IDF via matrix.test.idf_version if an example ever needs one. | ||
| esp_idf_version: ${{ matrix.test.idf_version || 'v6.0.1' }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development has been on ESP-IDF v6 for a while, and the
twaicomponent (used by thetwai/canopenexamples) requires the v6.0esp_driver_twainode API. This bumps the build matrix default fromv5.5.1tov6.0.1.esp_idf_versionis now${{ matrix.test.idf_version || 'v6.0.1' }}— the default is v6.0.1, but an optional per-entrymatrix.test.idf_versionhook remains so any single example can still pin a different IDF if it ever needs one.continue-on-error: true) will surface any example that does not yet build on v6 without blocking; those can be fixed as follow-ups.Note: overlaps with the
build.ymlchange in #748 (which added the per-entryidf_versionmechanism defaulting to v5.5.1 and pinned the three twai examples to v6.0). Whichever merges first, the other gets a trivial rebase — once this lands, #748’s threeidf_version: v6.0pins become redundant and can be dropped.🤖 Generated with Claude Code