Migrate API keys to the new Secret Storage API - #410
Open
vibbix wants to merge 8 commits into
Open
Conversation
Owner
|
Thank you, at first glance it looks great! I'm currently traveling and have very little computer time, but in a couple of weeks I'll invest time on Map View updates, and will give this a proper review & merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Currently, the API keys are just stored in the app settings. This isn't recommended anymore,
Changes
secretStorageTesting
Validated locally end-to-end
Disclosure
No LLM's were used to write any code as part of this ticket.