[pull] main from livekit:main - #480
Merged
Merged
Conversation
* Add SIPTransferError detail and deprecate TransferSIPParticipantResponse Every transfer outcome other than STR_COMPLETED is moving to an error. The reason cannot ride on the response, so it travels as a proto detail on the error instead, the same way SIPStatus already does. The detail nests the SIP status so a failed transfer needs only one detail, and reports it under the same twirp metadata keys a dialing failure uses. TransferSIPParticipantResponse is deprecated: it only still reports STR_CALL_ENDED, which is temporarily returned as a success. * Return the nested SIP status directly in SIPStatusFrom * Linting * Addressing comments * Replacing deprecation warning with a rollback comment * generated protobuf --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )