Repository navigation
ci: preserve OpenTelemetry proto 1.10.0 during Envoy updates - #528
Merged
Merged
Conversation
Signed-off-by: rulex123 <erica.manno@gmail.com>
Signed-off-by: rulex123 <erica.manno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proto updater now follows Envoy's API lockfile, which still explicitly selects OpenTelemetry proto 1.8.0. java-control-plane already ships definitions from 1.10.0, inherited from Envoy's former
repository_locations.bzl. The generated Envoy v1.40.2 update in #527 would therefore remove fields and change generated Java APIs and the experimental profiling schema.Keep OpenTelemetry explicitly at 1.10.0 while investigating the discrepancy with the Envoy community. Add the reason beside the pin and mark the generated
API_SHASentry as pinned for API compatibility. The existing checked-in proto definitions andAPI_SHASalready use 1.10.0, so this changes only the updater.Upstream history:
After merging this fix, rerun the scheduled proto updater to refresh #527 without the OpenTelemetry downgrade.