session persistence: always set cookie Path to / - #9950
Open
zhaohuabing wants to merge 3 commits into
Open
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9950 +/- ##
==========================================
+ Coverage 81.30% 81.33% +0.02%
==========================================
Files 264 264
Lines 40967 40953 -14
==========================================
Hits 33310 33310
+ Misses 7656 7642 -14
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The session persistence cookie was scoped to the matched HTTPRoute path, so it was never sent back when the client-visible path differs from the path Envoy matches, e.g. when an edge proxy rewrites / to /foo/bar before the request reaches the gateway. GEP-1619 now defaults the cookie Path to / instead of deriving it from the route match, so follow that guidance. Fixes envoyproxy#8580 Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Huabing (Robin) Zhao <huabing@tetrate.io>
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Huabing (Robin) Zhao <huabing@tetrate.io>
… unset Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com> Signed-off-by: Huabing (Robin) Zhao <huabing@tetrate.io>
zhaohuabing
force-pushed
the
session-cookie-path-root
branch
from
September 4, 2026 10:05
7254f18 to
c0b65f4
Compare
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The session persistence cookie was scoped to the matched HTTPRoute path, so it was never sent back when the client-visible path differs from the path Envoy matches, e.g. when an edge proxy rewrites
/to/foo/barbefore the request reaches the gateway.The GEP-1619 spec was changed in kubernetes-sigs/gateway-api#5046: the cookie
Pathnow defaults to/instead of being derived from the route match, and a newcookieConfig.pathfield lets users override it. This PR follows the new default. The explicitpathfield is not in Gateway API 1.6.2 yet, so wiring the override is left for the 1.7 bump.This is a breaking change: the cookie is now sent to every route on the same host, so HTTPRoute rules on the same host that enable cookie-based session persistence must use distinct
sessionNamevalues. Rules sharing asessionNameused to get separate cookies because their paths differed; they now overwrite each other's cookie. The release note and the session persistence task doc call this out.Related to #8580