feat(ratelimit): support ClusterSetting for ratelimit cluster - #9902
feat(ratelimit): support ClusterSetting for ratelimit cluster#9902zirain wants to merge 10 commits into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5d730073d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9902 +/- ##
==========================================
+ Coverage 81.32% 81.38% +0.05%
==========================================
Files 264 264
Lines 40964 41054 +90
==========================================
+ Hits 33315 33410 +95
+ Misses 7648 7643 -5
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1963bcb to
2a0e371
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
2a0e371 to
8a58c06
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d3b4593a7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This reverts commit 4d3b459. Signed-off-by: zirain <zirain2009@gmail.com>
803565c to
bbd229d
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
| // service, such as circuit breakers, timeouts, health checks, and load balancing. | ||
| // | ||
| // +optional | ||
| BackendSettings *ClusterSettings `json:"backendSettings,omitempty"` |
There was a problem hiding this comment.
Nit, the combination of BackendSettings and Backend is a bit confusing inside RateLimit.
There was a problem hiding this comment.
that's because backend in Ratelimit means the redis backend.
I used backenSetting to keep same as the one inside type BackendCluster struct, do you have a better name?
2 participants
this's useful if users want to custom the
maxRequestsPerConnectionforratelimit_clusterinstead of usingEnvoyPatchPolicywe may not need this if we agree to allow #9816 withoutMergeBackendenabled.