feat: emit warning policy status - #9896
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9896 +/- ##
=======================================
Coverage 81.29% 81.30%
=======================================
Files 263 263
Lines 40870 40903 +33
=======================================
+ Hits 33227 33256 +29
- Misses 7643 7647 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex review |
|
/retest |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acb606f410
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| continue | ||
| } | ||
|
|
||
| hasApplicableRoute = true |
There was a problem hiding this comment.
When a BackendTrafficPolicy contains only HTTP-specific settings such as retry and targets a UDP listener with an attached UDPRoute, this unconditionally marks the route applicable even though the UDP branch only applies load-balancer and DNS settings. The policy therefore remains absent from generated configuration but does not receive the new NoAttachedRoutes warning; the analogous unconditional TCP check has the same issue. Determine applicability from the configured features that can actually be applied to each protocol rather than merely from route presence.
Useful? React with 👍 / 👎.
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>
acb606f to
1502c88
Compare
1 participant
What this PR does / why we need it:
Currently, all policy status report
Accepted=trueeven when translator don't generate IR config.This case happen when policy attach some Gateway or ListenerSet and those listeners aren't attached with xRoutes.
Fixed: emit
NoAttachedRoutesReason withWarningcondition.Which issue(s) this PR fixes:
Fixes #9837
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.