Repository navigation
SHACL CI: check out CGMES-AP and NC-AP directly - #404
Open
BenedekFodor wants to merge 1 commit into
Open
BenedekFodor wants to merge 1 commit into
BenedekFodor wants to merge 1 commit into
Conversation
Since 2026-10-15 entsoe/application-profiles-library links CGMES/ and NCP/
as submodules (entsoe/CGMES-AP, entsoe/NC-AP). The workflow checked out the
library without submodules, so .apl-main/{CGMES,NCP}/PROF were empty and
validate_instances.py stopped with "cgmes-3.0: empty PROF map". Inside the
submodules the files also sit one folder deeper, so even a recursive
checkout would not match the paths prof_map.py expects.
Check out the two AP repos into .apl-cgmes and .apl-ncp instead; their
CGMES/ and NCP/ top-level layout matches prof_map.py unchanged. Update the
script defaults, CLAUDE.md local-run instructions and .gitignore to match.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Fbeni <fodor.benedek@gmail.com>
HarisVranaj
changed the base branch from
cgmes-3.0_ncp-2.5_tc-2.0
to
cgmes-3.0_ncp-2.5_tc-2.1
October 29, 2026 13:02
benceszirbik
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every SHACL validation run since 15 Oct 2026 fails before validating anything (e.g. #402, #403):
On 15 Oct
entsoe/application-profiles-librarymovedCGMES/andNCP/into separate repositories and linked them back as git submodules (entsoe/CGMES-AP,entsoe/NC-AP). The workflow checked out the library without submodules, so.apl-main/CGMES/PROFand.apl-main/NCP/PROFwere empty. Inside the submodule repos the files also sit one folder deeper (CGMES/CGMES/PROF), so a recursive checkout alone would not matchprof_map.pyeither.Fix
entsoe/CGMES-AP→.apl-cgmesandentsoe/NC-AP→.apl-ncp, and passes--apl cgmes-3.0=.apl-cgmes --apl ncp-2.5=.apl-ncp. TheirCGMES//NCP/top-level layout matchesprof_map.pyas it is; the hard-codedCGMES_COMMON_SHACL/NC_COMMON_SHACLpaths exist in the new repos.validate_instances.py: default paths, docstring and--aplhelp updated (no logic change).CLAUDE.md: local-run instructions clone the two AP repos..gitignore: ignores.apl-cgmes/and.apl-ncp/.Testing
Not run locally (no
uvon the machine). The push run of this branch exercises the workflow change; once merged, #402 and #403 need a re-push or rebase to re-run the check (the workflow triggers onpushonly).Note: the AP repos are still checked out at their default branch, unpinned — same exposure to upstream layout changes as before.
🤖 Generated with Claude Code