moving logs to post step - #7
Merged
Merged
Conversation
dben
force-pushed
the
dben/move-logs-to-post
branch
from
August 12, 2026 16:47
12982d3 to
e55f540
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Container App Jobs GitHub Action to improve Azure SDK error diagnostics and to defer Log Analytics log retrieval into a post step, while also modernizing the repo’s dependency/workflow tooling (pnpm, Node 24, semantic versioning, dependabot).
Changes:
- Added
logAzureErrorDetailsand integrated richer Azure SDK error logging across job lifecycle operations. - Moved job log retrieval to a new post action (
src/post.js) gated by job failure or a newpull-logsinput. - Migrated CI/release workflow to pnpm + Node 24, added dependabot config, and updated build outputs/lockfiles.
Reviewed changes
Copilot reviewed 10 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils.js |
Adds Azure error detail logging and tweaks Log Analytics log polling behavior. |
src/main.js |
Defers log retrieval to post step and saves state for post-action behavior. |
src/post.js |
New post action entrypoint that conditionally fetches job logs. |
src/job.js |
Improves Azure SDK error reporting and captures raw polling responses for better diagnostics. |
src/input.js |
Adds pull-logs input parsing and includes it in returned inputs. |
src/test.js |
Replaces placeholder test with coverage for new log-gating helpers. |
action.yml |
Adds pull-logs input and configures a post action entrypoint. |
package.json |
Switches build to produce a separate post bundle; adds pnpm/node engine metadata. |
pnpm-lock.yaml |
Introduces pnpm lockfile for dependency reproducibility. |
package-lock.json |
Removes npm lockfile in favor of pnpm lockfile. |
dist/post.js/package.json |
Declares ESM module type for the post bundle output directory. |
dist/post.js/360.index.js |
Adds compiled/bundled post-action artifact output. |
dist/360.index.js |
Updates compiled/bundled artifact output due to dependency/layout changes. |
.github/workflows/test-and-tag.yaml |
Updates CI to use pnpm/Node 24, publish JUnit, and automate semver/release behavior. |
.github/dependabot.yml |
Adds dependabot configuration for npm security and GitHub Actions updates. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the GitHub Action for running Azure Container App Jobs. The main enhancements include improved error reporting for Azure SDK operations, deferred job log retrieval until workflow completion, and expanded configuration for versioning and dependency management. The workflow now uses pnpm and Node.js 24, and semantic versioning is automated. Below are the most important changes:
Error Handling and Logging Improvements
logAzureErrorDetailsto log detailed Azure SDK error information, including status codes and raw response bodies, and integrated it throughout the codebase for better troubleshooting. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Job Log Retrieval Enhancements
src/post.js), ensuring logs are only fetched after workflow completion and only for failed jobs or when explicitly requested via the newpull-logsinput. [1] [2] [3] [4] [5] F0145afcL99R99, F0145afcL128R128, [6] [7]Workflow and Dependency Management
mikepenz/action-junit-reportaction. [1] [2] [3] [4]enosix/github-action-generate-semver..github/dependabot.ymlfile to manage npm and GitHub Actions dependencies with security-focused update groups.These changes collectively improve the reliability, maintainability, and usability of the action, especially around error diagnosis and log retrieval.