Skip to content

moving logs to post step - #7

Merged
dben merged 9 commits into
mainfrom
dben/move-logs-to-post
Aug 12, 2026
Merged

moving logs to post step#7
dben merged 9 commits into
mainfrom
dben/move-logs-to-post

Conversation

@dben

@dben dben commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces several improvements and new features to the GitHub Action for running Azure Container App Jobs. The main enhancements include improved error reporting for Azure SDK operations, deferred job log retrieval until workflow completion, and expanded configuration for versioning and dependency management. The workflow now uses pnpm and Node.js 24, and semantic versioning is automated. Below are the most important changes:

Error Handling and Logging Improvements

  • Added a new utility function logAzureErrorDetails to log detailed Azure SDK error information, including status codes and raw response bodies, and integrated it throughout the codebase for better troubleshooting. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Improved error reporting in job creation, execution, polling, and deletion, ensuring that more actionable information is available in workflow logs. [1] [2] [3] [4] [5]

Job Log Retrieval Enhancements

  • Deferred job log retrieval to a new post-action (src/post.js), ensuring logs are only fetched after workflow completion and only for failed jobs or when explicitly requested via the new pull-logs input. [1] [2] [3] [4] [5] F0145afcL99R99, F0145afcL128R128, [6] [7]
  • Added tests for the new log retrieval logic, confirming logs are only pulled when appropriate. [1] [2]

Workflow and Dependency Management

  • Migrated the workflow to use pnpm and Node.js 24, updated the build process, and switched to publishing test results using JUnit format and the mikepenz/action-junit-report action. [1] [2] [3] [4]
  • Automated semantic versioning and release tagging using enosix/github-action-generate-semver.
  • Added a .github/dependabot.yml file to manage npm and GitHub Actions dependencies with security-focused update groups.

These changes collectively improve the reliability, maintainability, and usability of the action, especially around error diagnosis and log retrieval.

@dben dben self-assigned this Aug 12, 2026
@dben
dben force-pushed the dben/move-logs-to-post branch from 12982d3 to e55f540 Compare August 12, 2026 16:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Azure Container App Jobs GitHub Action to improve Azure SDK error diagnostics and to defer Log Analytics log retrieval into a post step, while also modernizing the repo’s dependency/workflow tooling (pnpm, Node 24, semantic versioning, dependabot).

Changes:

  • Added logAzureErrorDetails and integrated richer Azure SDK error logging across job lifecycle operations.
  • Moved job log retrieval to a new post action (src/post.js) gated by job failure or a new pull-logs input.
  • Migrated CI/release workflow to pnpm + Node 24, added dependabot config, and updated build outputs/lockfiles.

Reviewed changes

Copilot reviewed 10 out of 17 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/utils.js Adds Azure error detail logging and tweaks Log Analytics log polling behavior.
src/main.js Defers log retrieval to post step and saves state for post-action behavior.
src/post.js New post action entrypoint that conditionally fetches job logs.
src/job.js Improves Azure SDK error reporting and captures raw polling responses for better diagnostics.
src/input.js Adds pull-logs input parsing and includes it in returned inputs.
src/test.js Replaces placeholder test with coverage for new log-gating helpers.
action.yml Adds pull-logs input and configures a post action entrypoint.
package.json Switches build to produce a separate post bundle; adds pnpm/node engine metadata.
pnpm-lock.yaml Introduces pnpm lockfile for dependency reproducibility.
package-lock.json Removes npm lockfile in favor of pnpm lockfile.
dist/post.js/package.json Declares ESM module type for the post bundle output directory.
dist/post.js/360.index.js Adds compiled/bundled post-action artifact output.
dist/360.index.js Updates compiled/bundled artifact output due to dependency/layout changes.
.github/workflows/test-and-tag.yaml Updates CI to use pnpm/Node 24, publish JUnit, and automate semver/release behavior.
.github/dependabot.yml Adds dependabot configuration for npm security and GitHub Actions updates.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread action.yml Outdated
Comment thread src/main.js
Comment thread src/post.js
Comment thread package.json
Comment thread src/utils.js Outdated
dben and others added 6 commits August 12, 2026 13:07
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@dben
dben requested a lite review from Copilot August 12, 2026 17:45
@dben
dben merged commit 1ccd9e2 into main Aug 12, 2026
5 checks passed
@dben
dben deleted the dben/move-logs-to-post branch August 12, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants