Repository navigation
Conversation
Add a new story quest made of an intro, a stealth level, a sequence puzzle level, three combat levels and an outro, with its own scripts, shaders, dialogues and assets. Everything is under scenes/quests/story_quests/el_hilo_que_no_teji/. Co-authored-by: Alan Jose Castillo Viera <byalan75@gmail.com> Co-authored-by: Jair Esnaider Monja Timana <elhuecho13@gmail.com>
…-teji Story quest: Add El Hilo Que No Tejí
|
Play this branch at https://play.threadbare.game/branches/GameLab6-UTP-Grupo3-Equipo2/main/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
…D solo en animaciones y evita la muerte doble
…-teji Usa el HUD global con la regla de 3 fragmentos por hilo y corrige HUD y muerte doble
|
For reference this was the former PR: #2428. I want to reference it because it has previous reviews. I just did a playthrough and whoa, this is impressive! Very good work! I love the story, the effects, and the level designs, reusing Threadbare mechanics in new and imaginative ways. Also thank you for updating it to latest Threadbare. |
manuq
left a comment
There was a problem hiding this comment.
- Please reduce the file size of WAV files:
- 16-bit samples at 44 kHz is plenty. Reduce them if needed (elian_laugh.wav is 24-bit).
- If they are stereo but both channels have the same data, use mono
- Remove silence or almost inaudible parts from the beginning or end of tracks
I have updated the wiki with these tips: https://github.com/endlessm/threadbare/wiki/Audio-Style-Guide#sound-effects
- I have ran
tools/check_orphan_assets.gdusing:
const ROOT_FOLDER := "res://scenes/quests/story_quests/el_hilo_que_no_teji"
And it looks like there are unused files. Please confirm and if so, remove them:
Other assets that nothing references: 7
res://scenes/quests/story_quests/el_hilo_que_no_teji/shared/assets/images/entities/lino/lino_collar_run.png uid://dwpxrvgd2pgwb
res://scenes/quests/story_quests/el_hilo_que_no_teji/shared/assets/images/entities/lino/lino_confused.png uid://b45pmfr80jn7r
res://scenes/quests/story_quests/el_hilo_que_no_teji/shared/assets/images/entities/lino/lino_run.png uid://eirajy3u850k
res://scenes/quests/story_quests/el_hilo_que_no_teji/shared/assets/images/entities/lino/lino_sleep.png uid://byqkyrwd7i6ur
res://scenes/quests/story_quests/el_hilo_que_no_teji/shared/assets/images/entities/lino/lino_walk.png uid://b2ddencnb7wq4
res://scenes/quests/story_quests/el_hilo_que_no_teji/shared/assets/sounds/enviroment/puente_cae.wav uid://btid3mejxbt67
res://scenes/quests/story_quests/el_hilo_que_no_teji/shared/assets/sounds/enviroment/puente_tablon.wav uid://dlqcif7isw0kv
There was a problem hiding this comment.
This wav file is too big (3.1MB), for only 10 seconds of audio.
First of, is 24-bit of depth, which is a lot. According to our audio style guide, 16-bit samples at 44 kHz is plenty.
Checking it I see that it's stereo, but the 2 channels are exactly the same. So please convert it to mono. Also remove the almost inaudible or silent part from the end of the track.
In fact, the largest files are all sounds in shared/assets/sounds/, 16 files of 11.2 MB size total:
| File | Size |
|---|---|
elian_laugh.wav |
3.1 MB |
Suspenso.wav |
1.5 MB |
elian_dissapear.wav |
1.2 MB |
intro_thunder_rain_lino.ogg |
1.1 MB |
elian_jar01.wav, elian_jar03.wav |
about 1 MB each |
El Hilo Que No Tejí follows Lino, who falls into El Deshilado, a world made of broken memories, after his dog Manchitas disappears. Following the barks of a mysterious shadow, he must face his guilt to find his dog. The quest has an intro, a stealth level, a sequence puzzle level, three combat levels and an outro.
This is a reworked version of the quest we submitted in [#2428], which was never merged and stayed as it was. That PR came from our team's earlier fork (https://github.com/GameLab6-UTP-Grupo3-Equipo2/threadbare), which was about three months behind upstream, with Godot 4.6 and the previous Dialogue Manager. Following Tobias's suggestion we tried a fresh branch, but the quest did not compile there because of parser errors. So we created a new fork from the current upstream, reworked and updated the quest on it, and are sending this PR from that new fork.
Assets
Original images - CC BY-SA 4.0:
Third-party assets (all CC0 1.0 unless noted; sources and licenses are also declared in the quest's REUSE.toml):
Engineering
The GameLab6-UTP-Grupo3-Equipo2 team (@Nox871, Alan Jose Castillo Viera, Jair Esnaider Monja Timana).
Game Design
The GameLab6-UTP-Grupo3-Equipo2 team.
Production & Management
The GameLab6-UTP-Grupo3-Equipo2 team.
Co-authored-by: Alan Jose Castillo Viera byalan75@gmail.com
Co-authored-by: Jair Esnaider Monja Timana elhuecho13@gmail.com