Skip to content

Preserve transfer state and reveal mobile table keyboard focus - #335

Merged
itlezy merged 8 commits into
mainfrom
fix/aich-proof-before-io
Nov 15, 2026
Merged

itlezy merged 8 commits into
mainfrom
fix/aich-proof-before-io

Conversation

@itlezy

@itlezy itlezy commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Preserve transfer state across invalid recovery data and failed persistence, and keep focused mobile table actions visible.

  • Validate AICH recovery proofs before reading raw payload bytes. Regressions retain manifest/attribution state on rejection and cover valid salvage, storage-error precedence and mandatory final MD4 verification. The broader request-correlation work in RUST-BUG-166 - Admit AICH recovery answers only for matching outstanding requests #250 remains open.
  • Restore failed peer-credit settlement through the existing saturating merge and propagate the original SQL error. Real SQLite failure, unchanged durable state, retained additions, retry and reopen are covered. The separate first-bind ordering race and broader persistence owner in RUST-REF-016 - Move blocking SQLite work behind bounded async persistence #155 remain unresolved.
  • Bound deletion-marker reads to 17 bytes on the same no-follow file handle. Invalid markers preserve payloads, identity and pending intent through restart/retry; restoring the exact UUID permits cleanup.

Mobile WebKit could focus an offscreen table action after arrow-key scrolling without revealing it, including through real Tab navigation. The existing table wrapper now reveals focused descendants with native nearest-edge scrolling. The regression uses Tab and retains focused-target, full-containment and page-overflow assertions.

The profile-default lifecycle fixture stages its executable by copying in the existing isolated helper process. The parent waits for successful helper exit before launching the staged image, keeping destination writer handles out of parallel parent spawns. This preserves the separate tmpfs required for Unix profile permissions and all executable-directory/explicit-profile checks. Explicit cleanup verifies the original executable survives. Earlier ETXTBSY and cross-mount hard-link EXDEV failures remain retained; the exact ETXTBSY scheduling was not captured.

Use accepted Builder 177bb6c7, Harness 17438846 and verified prepared image ba73b285. Producer/diagnostic Tooling contract pins remain f88a8ce6. The rusqlite test edge reuses the pinned workspace dependency.

Validation: 1,320 scoped eD2k tests passed on cfeb8c4; those transfer sources are unchanged. The final UI contribution passed 52 unit tests, 32 browser cases, TypeScript and production build. The final daemon fixture passed 120 Windows tests with one intentional ignored child helper. Normal hooks and independent source inspections accepted combined head c6b9cef. Earlier WebKit and Linux fixture failures remain retained; no unchanged-source rerun is used as the repair. The copy revision passed all 120 scoped Windows daemon tests, with one intentional ignored child helper. Full local musl x64 package validation passed, including workspace/VPN tests, the copied-executable fixture, and non-root lifecycle/local-transfer smoke. All four exact-head hosted workflows passed. The complete local gate passed all six stages on the frozen source set: Windows quality/workspace/VPN/REST checks; all four Linux GNU/musl architecture lanes and both container variants; and both Android ABIs with Clippy, diagnostics and test/release linking. Local ARM portable/durability proof is paired with the passed native hosted networking checks. All participating sources remained clean and unchanged; the owned WSL session stopped normally. All 30 hosted checks and four exact-head workflows also passed.

Refs #250 (RUST-BUG-166), #155 (RUST-REF-016), #226 (RUST-FEAT-056), #297 (RUST-CI-043). Closes #162 (RUST-BUG-136).

@itlezy

itlezy commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

The first complete local gate stopped in Windows WebUI tests: 31/32 end-to-end cases passed; WebKit at 390px failed the focused Remove button's horizontal containment assertion. The transfer changes leave the WebUI bytes unchanged from actual main e735319. This is the same assertion family as the earlier retained 320px failure, so a focused trace-based diagnosis and repair is now allocated under #226 rather than another blind retry.

The failing trace and error context are preserved, the owner exited with failure, and its WSL session stopped normally. This attempt supplies no Linux or Android full-gate pass. The 1,320 scoped eD2k tests and both source inspections remain valid evidence for the current transfer-source checkpoint. Complete local and hosted validation remains required on the repaired final head.

@itlezy itlezy changed the title Preserve transfer state across recovery and persistence failures Preserve transfer state and reveal mobile table keyboard focus Nov 15, 2026
@itlezy

itlezy commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

The musl failures exposed an invalid same-filesystem assumption in the earlier test-fixture repair. The existing Linux runner intentionally overlays profile scratch with an executable tmpfs to preserve Unix 0600 profile-permission tests; the Cargo executable remains on the output bind mount. Direct hard links therefore return EXDEV.

Current head c6b9cef keeps that layout and uses copying as the primary preparation step. The existing ignored helper copies its own executable and exits without spawning descendants; the parent waits for successful exit before launching the staged image. Destination writer descriptors never enter the parallel parent process. All original profile-path cases and explicit cleanup assertions remain. The revised fixture passed 120 scoped Windows daemon tests; actual musl full-package validation is running before the full matrix restarts. Earlier failed evidence is retained, with no unchanged-source rerun used as the repair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUST-BUG-136 - Bound transfer deletion marker validation reads

1 participant