Skip to content

Fix settings PATCH admission and logical profile lease release - #334

Merged
itlezy merged 5 commits into
mainfrom
fix/settings-patch-validation
Nov 15, 2026
Merged

itlezy merged 5 commits into
mainfrom
fix/settings-patch-validation

Conversation

@itlezy

@itlezy itlezy commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Standalone useServerPriorities and autoConnectStaticOnly PATCH requests were rejected as empty, while explicit null NAT booleans could disappear beside a valid sibling. Repair the existing admission predicates and strict boolean validation; preserve atomic persistence and ordered publication.

Immediate profile reopen could also fail after the final parent owner dropped: a macOS subprocess can transiently retain an inherited file description. Profiles and metadata stores now share one typed, acquisition-PID-aware guard. The final logical owner releases its acquired descriptor after connection teardown; an inherited child cannot unlock the parent's lease. No sleeps, lock retries, fixture serialization or path-based unlocking are added.

The reviewed Android README links use maintained platform guides and valid repository notices. No settings schema, defaults, bootstrap shape or migration changes are included.

Validation:

  • Scoped settings/REST regressions passed; all 156 REST tests passed again on combined head d6e44b1 after the lease repair. The lease contribution passed 104 metadata and 120 daemon tests on Windows, with one existing ignored subprocess fixture.
  • Two inspection rounds accepted the settings repairs and the lease guard, including deterministic duplicate-descriptor, retained-owner, constructor-error and inherited-child regressions. The GNU/Linux full gate has executed and passed the duplicate-descriptor, inherited-child and constructor-error Unix regressions; fresh exact-head hosted Linux/macOS checks also passed.
  • Normal hooks passed. All exact-head hosted CI, CodeQL, optional-platform and branch checks passed. The fresh complete local gate passed all six stages on the frozen source set: Windows, all four Linux GNU/musl architecture lanes and both container variants, plus ARM64/x86_64 Android Clippy, diagnostic and test/release linking. Linux ARM64 networking is covered by the passed native hosted checks; local portable/durability proof is retained. Source revisions remained clean and unchanged, and the owned WSL session stopped normally. The earlier local gate was deliberately interrupted for this repair; its partial Windows pass is not a full pass.
  • Retained macOS failures led to the source-backed ownership repair. The first 320px WebKit focus-containment failure remains retained; its single unchanged rerun passed, with cause unconfirmed.

The broader settings/revision/ETag proposal stays unaccepted and #297 remains open. Refs #297 (RUST-CI-043), #226 (RUST-FEAT-056).

@itlezy itlezy changed the title Fix standalone settings patches and strict NAT boolean validation Fix settings PATCH admission and logical profile lease release Nov 15, 2026
@itlezy
itlezy merged commit e735319 into main Nov 15, 2026
30 checks passed
@itlezy
itlezy deleted the fix/settings-patch-validation branch November 15, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant