Repository navigation
Fix settings PATCH admission and logical profile lease release - #334
Merged
Merged
Conversation
added 5 commits
November 15, 2026 02:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone useServerPriorities and autoConnectStaticOnly PATCH requests were rejected as empty, while explicit null NAT booleans could disappear beside a valid sibling. Repair the existing admission predicates and strict boolean validation; preserve atomic persistence and ordered publication.
Immediate profile reopen could also fail after the final parent owner dropped: a macOS subprocess can transiently retain an inherited file description. Profiles and metadata stores now share one typed, acquisition-PID-aware guard. The final logical owner releases its acquired descriptor after connection teardown; an inherited child cannot unlock the parent's lease. No sleeps, lock retries, fixture serialization or path-based unlocking are added.
The reviewed Android README links use maintained platform guides and valid repository notices. No settings schema, defaults, bootstrap shape or migration changes are included.
Validation:
The broader settings/revision/ETag proposal stays unaccepted and #297 remains open. Refs #297 (RUST-CI-043), #226 (RUST-FEAT-056).