Define the polyfills of DynamicallyAccessedMembers only where they are missing - #383
Open
AlexanderV wants to merge 1 commit into
Open
Define the polyfills of DynamicallyAccessedMembers only where they are missing#383AlexanderV wants to merge 1 commit into
AlexanderV wants to merge 1 commit into
Conversation
…e missing Both DynamicallyAccessedMembersAttribute and DynamicallyAccessedMemberTypes were compiled for every target framework below .NET 8. Both types exist since .NET 5, so compiling the sources for .NET 6 or .NET 7 fails with CS0433, because the type exists in PdfSharp.Shared and in System.Runtime. They are now compiled for .NET Framework 4.6.2 and .NET Standard 2.0 only, which is where they are really missing. The target frameworks PDFsharp is built for are not affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamicallyAccessedMembersAttributeandDynamicallyAccessedMemberTypesinPdfSharp.Shared/dotnet/CodeAnalysis.csare compiled for every target framework below .NET 8:Both types exist since .NET 5, so building the sources for .NET 6 or .NET 7 fails with
CS0433— the type exists in bothPdfSharp.SharedandSystem.Runtime(388 errors in my build fornet6.0).The condition is now
NET462 || NETSTANDARD2_0, i.e. the polyfills are compiled where the types are really missing.PdfSharp.System/dotnet/CodeAnalysis.csalready disables its copy for the same reason.No effect on the target frameworks PDFsharp is built for today — the block was already excluded for net8.0/net9.0/net10.0 and is unchanged for netstandard2.0.
Verified on top of current
master: builds fornet10.0andnetstandard2.0, fullPdfSharp.Testssuite green (252 passed, 0 failed).This PR is independent of my other PRs; each of them applies to
masteron its own.