fix: check *ret instead of ret in xvasprintf error path - #96
Open
kugland wants to merge 1 commit into
Open
Conversation
ret is the address of a local char* and is never NULL, so the OOM branch was dead. Test len == -1 first to short-circuit, since per vasprintf(3) the contents of *strp are undefined on error on GNU; the *ret == NULL check then covers the FreeBSD case, where the implementation sets strp to NULL on error.
emikulic
reviewed
Aug 15, 2026
| static unsigned int xvasprintf(char **ret, const char *format, va_list ap) { | ||
| int len = vasprintf(ret, format, ap); | ||
| if (ret == NULL || len == -1) | ||
| if (len == -1 || *ret == NULL) |
Owner
There was a problem hiding this comment.
Can this condition be simplified to just len == -1?
man 3 printf on FreeBSD says vasprintf() will return -1
Owner
|
Sorry for delay. Nice catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retis the address of a localchar*and is never NULL, so the OOM branch was dead. Testlen == -1first to short-circuit, since pervasprintf(3)the contents of*strpare undefined on error on GNU; the*ret == NULLcheck then covers the FreeBSD case, where the implementation setsstrpto NULL on error.