Repository navigation
Replace TokenType and TokenizerState enums with literal union types - #123
Merged
Merged
Conversation
BREAKING CHANGE: `TokenType` and `TokenizerState` are now type-only
exports (string literal unions) rather than TypeScript enums, so they no
longer exist at runtime.
The underlying values are unchanged: tokens still have `type: 'StartTag'`
etc., and tokenizer states are still the same camelCase strings, so code
that compares against string literals is unaffected.
Code that used the enums as values must switch to string literals:
// before
if (token.type === TokenType.StartTag) { ... }
tokenizer.transitionTo(TokenizerState.data);
// after
if (token.type === 'StartTag') { ... }
tokenizer.transitionTo('data');
Importing `TokenType` or `TokenizerState` for use in type positions
continues to work. Consumers compiling with `isolatedModules` or
`verbatimModuleSyntax` should re-export them with `export type`.
The tokenizer-states codegen now emits a union type as well.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TokenTypeandTokenizerStateare now type-only exports (string literal unions) rather than TypeScript enums, so they no longer exist at runtime.In modern typescript, string literal union types are a better alternative to exported enums. They don't have the same compilation caveats and they result in shorter, easier-to-read consumer code with no loss of safety.