Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rvn9nzW2qDp8TtbmZ4mEve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same changes as the CI updates and pnpm switches in ember-cli-deploy-s3 (#196, #211), ember-cli-deploy-s3-index (#146, #151) and ember-cli-deploy-revision-data (#105, #108). Here they're one PR because they edit the same workflow lines.
CI
14.x, 16.x, 18.x, 20.x→20.x, 22.x, 24.xactions/checkoutv2 → v4,actions/setup-nodev2 → v4.setup-node@v2withcache: 'yarn'uses GitHub's retired cache service, which now fails every job during setup (this broke ember-cli-deploy-s3-index's CI). This repo hasn't had a CI run since 2023, so it hadn't shown up yet.pnpm/action-setup@v6;pnpm install --frozen-lockfilefor Test,pnpm install --no-lockfilefor Floating Dependencies.pnpm
yarn.lock→pnpm-lock.yaml, generated withpnpm importso every resolved version carries over unchanged.packageManager: pinpnpm@12.15.0(with checksum).pnpm-workspace.yaml:allowBuilds: { core-js: false }. pnpm 12 fails the install on unapproved build scripts; core-js 2 (via ember-cli) only prints a funding banner.pnpm test/pnpm release.No change to the published package: dependencies and
enginesare untouched.Testing
On Node 20.19.0, locally:
pnpm install --frozen-lockfile+pnpm test: 43 passing, ESLint cleanpnpm install --no-lockfile+pnpm test: 43 passing🤖 Generated with Claude Code
https://claude.ai/code/session_01Rvn9nzW2qDp8TtbmZ4mEve