Release 0.10.0 - #71
Merged
Merged
Conversation
Bump every package to 0.10.0 and close the changelog's Unreleased section. `phpstan', `flycheck-phpstan', `flymake-phpstan', and `phpstan-hover' are released together, and the sub-packages rely on this phpstan release -- the flycheck generic-checker rewrite and the flymake JSON parser both use phpstan.el internals introduced here -- so their `Package-Requires' now ask for `(phpstan "0.10.0")'. `phpstan-hover.el' gains a `Version' header to match the other files; it had none. 0.10.0 rather than 0.9.1 because this raises the Emacs floor to 27.1 (dropping 26), obsoletes `phpstan-flycheck-auto-set-executable', and adds Apple container support and `phpstan-hover-mode'. The obsolete declaration already named 0.10.0 as the version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR for 0.10.0. Merge this, then tag
0.10.0on master.Version bumps
Version:header → 0.10.0 inphpstan.el,flycheck-phpstan.el,flymake-phpstan.el, andphpstan-hover.el.EaskandEask.27package version → 0.10.0.CHANGELOG.md:## Unreleased→## [0.10.0].Two judgment calls — please confirm
Sub-package dependency bumped to
(phpstan "0.10.0")inflycheck-phpstan,flymake-phpstan, andphpstan-hover. They're released in lockstep and genuinely need this phpstan release — the flycheck generic-checker rewrite and the flymake JSON parser both use phpstan.el internals introduced in this cycle — so requiring the older 0.9.0 would allow a broken mix. Tell me if you'd rather keep it at 0.9.0.phpstan-hover.elgained aVersionheader (it had none). Added for consistency with the other package files. If it was omitted on purpose (experimental, not yet on MELPA), say so and I'll drop it.Why 0.10.0
Not a patch (0.9.1): this raises the Emacs floor to 27.1 (dropping Emacs 26), obsoletes
phpstan-flycheck-auto-set-executable, and adds Apple container support andphpstan-hover-mode. In 0.x, a minor bump carries these. The obsolete declaration inphpstan.elalready named"0.10.0", so this matches.Not 1.0.0: the internals were just reworked heavily; staying on 0.x a bit longer reads as more honest than declaring API stability now.
What's in 0.10.0
The full list is in the changelog. Headline items:
Added —
phpstan-hover-mode(experimental); Applecontaineras aphpstan-executable.Changed —
flycheck-phpstanis now a generic checker (no more injecting an executable via:enabled, nophprequired inexec-path);flymake-phpstanreads JSON, reaching parity with flycheck (identifiers, tips, andphpstan-insert-ignore/phpstan-copy-dumped-typenow work from Flymake).Fixed — a cascade uncovered while reworking the checker: Docker/container never actually worked through Flycheck (host paths sent to the container, JSON hidden behind STDERR progress, failures swallowed as a clean buffer); editor-mode version detection probed the wrong program;
phpstan-get-command-argsmutated its inputs and dropped the command name; JSONfalse/nullread as truthy so non-ignorable errors looked ignorable; and more.Removed — Emacs 26 and earlier.
Verification
This release also adds the package's first test suite (25 ERT tests) and runs it in CI across Ubuntu/macOS/Windows on Emacs 27.2 through snapshot. All green on this branch;
make testand compile are clean locally on system Emacs and Emacs 27.2.