Close connection after error on open#351
Merged
Merged
Conversation
This is a behaviour that docs describe as correct: > Whether or not an error occurs when it is opened, resources associated > with the database connection handle should be released by passing it > to sqlite3_close() when it is no longer required. https://www.sqlite.org/c3ref/open.html
warmwaffles
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per documentation, even when the database opening failed, we should still run
sqlite3_close()to free the resources:I verified this against Python implementation, which does this too. Python also calls
assertto make sure that closing was clean (it should be per a comment there), but I think it's not a good idea for a NIF to do such thing.AI disclosure
The issue was flagged by an AI review while I was working on SQLite backend for Expert. The rest of the work was human.