chore: Move to Nx 1.0 - #370
Open
georgeguimaraes wants to merge 1 commit into
Open
georgeguimaraes wants to merge 1 commit into
georgeguimaraes wants to merge 1 commit into
Conversation
Widens the requirement to nx ~> 0.13 or ~> 1.0 and moves the lock to 1.0.0. Nx needs override: true in the test build because scidata pulls in stb_image, whose optional nx ~> 0.4 still caps it. Six doctests carried exact SVD, ridge regression and truncated SVD values that shift in the sixth digit with the linalg fixes in Nx 1.0, updated to the new outputs.
Contributor
|
@georgeguimaraes stb_image is out, can we perhaps remove override: true? |
Member
Author
|
Tried it, and it's actually polaris that blocks it, not stb_image. Dropping the override fails resolution because polaris 0.1.0 pins So the override stays until there's a polaris release that allows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nx 1.0.0 is out and
nx ~> 0.13keeps it out of the resolver. This widens it to~> 0.13 or ~> 1.0and moves the lock to 1.0.0.Nx gets
override: truebecause polaris 0.1.0 pinsnx ~> 0.5and there's no polaris release that allows 1.0 yet. Only affects Scholar's own build. It can go once polaris ships a release with a wider nx requirement.Six doctests had exact float values from SVD, ridge regression and truncated SVD that move in the sixth digit with the linalg fixes in Nx 1.0, so they're updated to the new outputs.