Repository navigation
Test the newest Nx release in CI - #56
Open
reidmorrison wants to merge 2 commits into
Open
reidmorrison wants to merge 2 commits into
reidmorrison wants to merge 2 commits into
Conversation
CI only tests the Nx version in mix.lock (0.6.2), although Ortex now allows Nx 1.0. Since Nx 0.8 several operations, such as stack, call the backend directly, so problems that only show up on newer Nx go unnoticed. Add an "Nx latest" variant of the Linux job. It unlocks nx and complex (Nx 1.x needs complex 1.x) before fetching dependencies. Both variants now fetch only the test dependencies, because the dev-only exla and torchx 0.6 still require Nx 0.6 and would block resolving Nx 1.x.
Answers /code-review high of ci-nx-latest at a0bbcda: - Unlocking "nx complex" by hand lists Nx's dependencies in the workflow. If a later Nx needs a newer version of another locked dependency, Hex quietly resolves an older Nx and the "latest" leg stops testing the newest release. "mix deps.update nx --only test" updates Nx together with its own dependencies. - The new two-leg matrix kept the default fail-fast, so a failure on "Nx latest" cancelled "Nx locked". Set fail-fast: false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #54. CI only tests the Nx version in
mix.lock(0.6.2), so problems that only show up on newer Nx go unnoticed. For example, since Nx 0.8Nx.stack/2calls the backend'sstackdirectly, which Ortex doesn't implement yet (fixed in #57).This adds an "Nx latest" variant of the Linux job that runs
mix deps.update nx --only test(which also updates Nx's own dependencies, such ascomplex) before fetching dependencies. Both variants now runmix deps.get --only test, because the dev-onlyexlaandtorchx0.6 still require Nx 0.6 and would otherwise block resolving Nx 1.x.fail-fast: falsekeeps a failure in one variant from cancelling the other.I ran both variants' steps locally: all 117 tests pass on Nx 0.6.2 and on Nx 1.0.0.
Code Review.
nx complexby hand could quietly resolve an older Nx once a future Nx needs a newer version of another locked dependency. The step now runsmix deps.update nx --only test.fail-fast, so a failure on Nx latest cancelled the Nx locked run. It now setsfail-fast: false.