Keep metric accumulators and transforms during validation - #679
Open
georgeguimaraes wants to merge 1 commit into
Open
georgeguimaraes wants to merge 1 commit into
georgeguimaraes wants to merge 1 commit into
Conversation
validate/4 re-registered the loop's metrics on the evaluator from their raw functions with the default accumulator and fields, so a metric declared with a custom transform or accumulator computed something else during validation, or failed when its function did not take y_true and y_pred. The evaluator now takes the metrics as they were declared.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate/4re-registered the loop's metrics on the evaluator from their raw functions with the default accumulator and fields, so a metric declared with a custom transform or accumulator computed something else during validation, or failed outright when its function did not takey_trueandy_pred. The evaluator now takes the metrics as they were declared. Found while working on #676, whose special case invalidate/4this makes unnecessary.