Repository navigation
Conversation
Coverage Report for CI Build 0Coverage decreased (-0.05%) to 90.572%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Mint.HTTP2 checked that a PUSH_PROMISE carried non-empty :scheme and :authority pseudo-headers but never compared them to the connection, so a server on https://a.example could promise a response for https://b.example and Mint returned it to the caller as a :push_promise. RFC 9113 8.4.1 requires the client to check that the server is authoritative for a pushed request and to treat a push that fails the check as a stream error of type PROTOCOL_ERROR. A caller that stores pushed responses under the promised URL would otherwise store another origin's content. Pushes are now accepted only for the connection's own origin: the promised :scheme must equal the connection's scheme and the promised :authority must equal the connection's authority, ignoring case and an explicit default port. Other pushes reset the promised stream with PROTOCOL_ERROR, like the other invalid promised requests. RFC 9113 10.1 also allows pushes for any origin covered by the server's certificate, which Mint doesn't track per connection, so those are reset as well.
ericmj
force-pushed
the
push-promise-authority
branch
from
November 16, 2026 21:09
5f5ef66 to
ce370fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mint.HTTP2 returned a PUSH_PROMISE to the caller whatever its
:schemeand:authoritywere, so a server onhttps://a.examplecould promise a response forhttps://b.example. RFC 9113 8.4.1 requires the client to check that the server is authoritative for a pushed request and to treat a push that fails the check as a PROTOCOL_ERROR stream error. This affects callers that keep push enabled (the default) and store pushed responses under the promised URL. Finch and Req disable push, and the Tesla and grpc Mint adapters drop pushed responses, so none of them are affected.Pushes are now accepted only when the promised
:schemeand:authoritymatch the connection, ignoring case and an explicit default port. Other pushes reset the promised stream with PROTOCOL_ERROR, the same as other invalid promised requests, and the server push docs say so. RFC 9113 10.1 also allows pushes for other origins covered by the server's certificate. Mint doesn't track that per connection, so it resets those too.Reported by @Divsonar.