Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/ex_unit/lib/ex_unit/cli_formatter.ex
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,13 @@ defmodule ExUnit.CLIFormatter do
true -> IO.puts("\n")
end

IO.puts(formatted)
formatted
|> ensure_printable()
|> IO.puts()
end

defp ensure_printable(binary) do
if String.valid?(binary), do: binary, else: String.replace_invalid(binary)
end

defp format_type_counts(type_counter) do
Expand Down
23 changes: 23 additions & 0 deletions lib/ex_unit/test/ex_unit_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -1281,4 +1281,27 @@ defmodule ExUnitTest do
defp max_failures_reached_msg() do
"--max-failures reached, aborting test suite"
end

test "reports failures with invalid UTF-8 in messages" do
defmodule InvalidUtf8Test do
use ExUnit.Case

test "poisoned" do
flunk("frame bytes: " <> <<0xC3, 0x28, 0xFF>>)
end

test "clean" do
flunk("never silenced")
end
end

output =
capture_io(fn ->
assert ExUnit.run() == %{total: 2, excluded: 0, failures: 2, skipped: 0}
end)

assert String.valid?(output)
assert output =~ "frame bytes:"
assert output =~ "never silenced"
end
end
Loading