chore: Fail on empty action sets - #697
Draft
nicow-elia wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Nico Westerbeck <Nico.Westerbeck@50hertz.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an early validation in the DC genetic algorithm setup path to fail fast when the loaded action set is empty, preventing the optimizer from starting in a non-actionable configuration.
Changes:
- Add an explicit runtime check in
algo_setup()that raises whenn_actions == 0. - Surface a clearer failure mode earlier in initialization rather than proceeding into verification/optimization.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+434
to
+435
| if static_informations[0].dynamic_information.n_actions == 0: | ||
| raise ValueError("No actions present in the action set, can not optimize.") |
Comment on lines
+434
to
+436
| if static_informations[0].dynamic_information.n_actions == 0: | ||
| raise ValueError("No actions present in the action set, can not optimize.") | ||
|
|
nicow-elia
marked this pull request as draft
August 27, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Please check if the PR fulfills these requirements:
Does this PR already have an issue describing the problem?
Fixes #
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?