Skip to content

meson: Always assume style sheet targets are stale - #1049

Merged
danirabbit merged 1 commit into
mainfrom
leolost/always-stale
Sep 17, 2026
Merged

danirabbit merged 1 commit into
mainfrom
leolost/always-stale

Conversation

@leolost2605

Copy link
Copy Markdown
Member

Add build_always_stale to the style sheet custom targets. This is because we only pass the top level file to the custom target and sassc imports the rest. However because of that meson doesn't know about the rest and doesn't rebuild the targets if the top level hasn't changed. Therefore tell meson the targets are always stale as compiling them doesn't take that long.

Add build_always_stale to the style
sheet custom targets. This is because we only pass the
top level file to the custom target and sassc
imports the rest. However because of that meson
doesn't know about the rest and doesn't rebuild the
targets if the top level hasn't changed.
Therefore tell meson the targets are always stale
as compiling them doesn't take that long.
@leolost2605

Copy link
Copy Markdown
Member Author

With this no ninja clean is needed when a sublevel .scss file was changed. Currently ninja clean is needed right or am I missing something?

@leolost2605
leolost2605 requested a review from a team September 17, 2026 08:47
@stsdc

stsdc commented Sep 17, 2026

Copy link
Copy Markdown
Member

I have the same issue with Monitor. Always have to use ninja clean if I'm dealing with a style changes. This change worth to apply in other repos.

@danirabbit
danirabbit merged commit 0d6ab67 into main Sep 17, 2026
3 of 5 checks passed
@danirabbit
danirabbit deleted the leolost/always-stale branch September 17, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants