Fix progress bar dialog for trash, restore and empty trash file operations - #2827
Fix progress bar dialog for trash, restore and empty trash file operations#2827vjr wants to merge 12 commits into
Conversation
Very embarrassingly rough work. Sync likely working for trash, restore from trash and empty trash. Trash files progress dialog working as before. Restore from trash progress dialog still does not show up.
|
@jeremypw there's some improvement towards fixing the issue. With this branch on occasion the progress bar dialogs do not show up and I get the process-not-responding busy dialog "wait or kill" especially if I perform multiple steps in the same app lifetime - meaning if I close and restart the app for each step (trash files, restore files, empty trash) it seems to work. You mentioned an "undo manager" here -> #137 (comment) which I'm not familiar with nor any other subsystems that might be slowing down/interacting when there are large number of files - I've been testing with 10,000 files of 100k each. I've disabled options such as local/remote thumbnailing, file previews etc. One other issue (existing on main branch too) I see is there is no confirmation dialog popup when you empty trash with large number of files (in my test with 10,000 files) but if I empty with just a few it shows up. |
|
@vjr Thanks for your continued work on this! I'll have a look at it tomorrow. |
|
@vjr On reflection, it would be better to wait for your existing sync PR to be merged before looking at this so we can focus on one thing and fix any conflicts then. I am also touching some of the same code in my port to Vala of delete/trash operations. I may be able to fix the progress in Vala. |
2 participants
Fixes #137