docs: cover the five new with_context tests and drop accepted_range - #2338
Open
joostboon wants to merge 2 commits into
Open
docs: cover the five new with_context tests and drop accepted_range#2338joostboon wants to merge 2 commits into
joostboon wants to merge 2 commits into
Conversation
Adds expression_is_true_with_context, not_empty_string_with_context, expect_column_pair_values_A_to_be_greater_than_B_with_context, expect_compound_columns_to_be_unique_with_context and expect_column_values_to_match_regex_list_with_context. Removes accepted_range_with_context, which no longer ships. Corrects two things that are no longer true. The regex test carried a "Requires dbt_expectations to be installed" note; the tests now use a native implementation and need no extra packages, so the intro says that explicitly. In its place the regex tests carry a warning that T-SQL has no regex functions, so they are unsupported on SQL Server and Fabric. Also notes that expression_is_true_with_context is table-level and therefore needs every wanted column listed under context_columns, which is the one non-obvious thing about it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
The page had removed it outright, which no longer matches the package: it now ships as a deprecated test that logs a warning and is scheduled for removal in the next release. Published docs and the stored test description disagreed. Adds it back at the end of the page, marked deprecated, with the migration to dbt_utils.accepted_range and a pointer to the sampling controls for the one thing it could do that the replacement cannot: narrowing a stored sample. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the changes in dbt-data-reliability#1046.
Single page touched:
data-tests/with-context-tests. It is already indocs.json, so there is no navigation change.Added
Five new tests, slotted next to the tests they relate to rather than appended:
expression_is_true_with_contextnot_empty_string_with_contextexpect_column_pair_values_A_to_be_greater_than_B_with_contextexpect_compound_columns_to_be_unique_with_contextexpect_column_values_to_match_regex_list_with_contextRemoved
accepted_range_with_context, which no longer ships. The range use case is now covered by anexpression_is_true_with_contextexample, so the capability is still discoverable without documenting a test that is gone.Corrected
Two statements on the page that are no longer true:
<Info>saying it requiresdbt_expectationsto be installed. That dependency is gone. The intro now states positively that these tests need no extra packages, which is the thing users will actually search for.<Warning>that they are unsupported on SQL Server and Microsoft Fabric, since T-SQL has no regex functions and the test raises a compilation error there. This is a real constraint that was previously undocumented.Also
expression_is_true_with_contextis table-level, so unlike every other test on the page it has no tested column to seed the sample with. Every wanted column has to be listed undercontext_columns. That is the one genuinely surprising thing about it, so it is called out in a<Note>rather than left to be discovered.Checks
mintlify broken-linkspasses (success no broken links found). Components and code fences verified balanced.🤖 Generated with Claude Code