Skip to content

Fix HAL_UART_ErrorCallback wedging the system when the Rx listener errors #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonwaterschoot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix HAL_UART_ErrorCallback wedging the system when the Rx listener errors #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/per/uart.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,8 +1104,17 @@ extern "C" void HAL_UART_RxHalfCpltCallback(UART_HandleTypeDef* huart)

extern "C" void HAL_UART_ErrorCallback(UART_HandleTypeDef* huart)
{
auto* handle = MapInstanceToHandle(huart->Instance);
handle->listener_mode_ = false;
auto* handle = MapInstanceToHandle(huart->Instance);
if(handle && handle->listener_mode_)
{
/** Listening has stopped: report that via IsListening(), and undo the
* IDLE interrupt DmaListenStart() enabled. Leaving IDLE armed while
* listener_mode_ is false means nothing ever clears the flag --
* UART_IRQHandler only does so inside the listener branch -- and the
* interrupt re-asserts forever. DmaListenStop() disables both. */
handle->listener_mode_ = false;
__HAL_UART_DISABLE_IT(huart, UART_IT_IDLE);
}
UartHandler::Impl::DmaTransferFinished(huart, UartHandler::Result::ERR);
}

Expand Down
Loading