Repository navigation
ci: add eval and lint gate - #4
Merged
Merged
Conversation
Moves the pins into flake.lock, as r-pkgs does, so `nix flake update` maintains them. pins.nix still uses builtins.fetchGit, so evaluation keeps working on Nix 2.3. nix-lib now follows corepkgs/nix-lib, which bumps it from 9acd37c to 548c00d. Every buildable drvPath is unchanged. The flake also gains legacyPackages and corepkgs' formatter.
gnum4 is an alias for m4, so evaluation fails with aliases disabled.
luajitPackages is an alias for lua.luajit_2_1.pkgs, so evaluation fails with aliases disabled. It also pulled LuaJIT 2.1's magick into every set, whatever that set's interpreter. magick is a LuaJIT FFI binding that is disabled outside Lua 5.1 and LuaJIT, so image-nvim is now marked broken there as well.
Applies `nix fmt` (corepkgs' treefmt configuration). Formatting only: every buildable drvPath is unchanged.
Mirrors corepkgs' and r-pkgs' gate: - lint: `nix fmt . -- --ci` - eval: ci/eval.sh evaluates every package in every lua.variants set with aliases disabled. It fails on anything tryEval cannot catch, and on evaluation warnings. luarocks-nix is excluded. It is defined in corepkgs and takes `nurl`, which corepkgs does not package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an eval and lint gate like corepkgs' and r-pkgs', plus the fixes it needs to pass.
Gate
nix fmt . -- --ci, using corepkgs' treefmt configuration (exposed as this flake'sformatter).ci/eval.shevaluates every package in everylua.variants.<v>.pkgsset: Lua 5.1–5.5, the_compatvariants and the three LuaJITs, 2700 packages in all. Aliases are disabled. The job fails on errorstryEvalcannot catch (a missingcallPackageargument, a missing attribute, a type error) and on evaluation warnings. Packages that are broken, disabled or unsupported on a given interpreter throw a catchable error and are allowed.luarocks-nixis excluded. It is defined in corepkgs (pkgs-many/lua/luarocks/luarocks-nix.nix) and takesnurl, which corepkgs does not package, so lua-pkgs can't fix it. The exclusion list inci/packages.nixsays to drop the entry once corepkgs is fixed.Commits
flake.lock;pins.nixreads them withbuiltins.fetchGit, as in r-pkgs. nix-lib now followscorepkgs/nix-lib, which bumps it from 9acd37c to 548c00d.gnum4→m4.gnum4is an alias.luajitPackages.magick→magickfrom the package's own set.luajitPackagesis an alias, and it also pulled LuaJIT 2.1's magick into every interpreter's set. magick is a LuaJIT FFI binding, disabled outside Lua 5.1 and LuaJIT, so image-nvim is now marked broken on 5.2+ too.nix fmt, formatting only (41 files).ci/and a README section.Testing
./ci/eval.shpasses on Nix 2.34 and on Nix 2.3.16.nix fmt . -- --ciis clean.v5_2.cqueuesluajit_2_1.image-nvimv5_1.image-nvim