refactor: migrate to cpp-core submodule and enforce pin in CI#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the AoC refactor to consume
cpp-corethrough a pinned git submodule and adds CI enforcement for the submodule pin contract.What changed
cpp-coreas a submodule atthird_party/cpp-coreand pinned it to release tagv1.0.1.makefileto compile AoC modules plus core modules from the submodule source root.src/base/.core_debug.hvia include path.ci/verify_cpp_core_submodule.sh.make verify-submodule-pin.README.mdwith submodule setup, verification, and layout updates.docs/CONTRIBUTING.mdwith submodule contract and bump workflow.docs/Doxyfileinput to includethird_party/cpp-core/src..github/workflows/verify-cpp-core-pin.ymlmake verify-submodule-pinonpull_requestandpushtomain.Validation
make verify-submodule-pinmake debugmake releasemake ltomake instrument./build/aoc_worker_debug 2015 1 1make docsSmoke output for day 1 part 1 remains unchanged (
138).Notes