Repository navigation
feat(ui): block settings menu as a plugin surface #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gohabereg
wants to merge
38
commits into
main
Choose a base branch
from
feat/block-settings-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
96c3a63
test(ui): give the package a Jest harness
gohabereg 1ab4201
feat(ui): add the block settings menu plugin
gohabereg e2325b8
feat(ui): open block settings from the toolbar
gohabereg 41c200b
feat(default-block-settings-plugin): move, move and delete as a plugin
gohabereg fc7053f
feat(editorjs): ship the block settings menu in the bundle
gohabereg c326a8b
fix(ui): let block settings rows fill the menu
gohabereg 6cc8510
test(editorjs): cover the block settings menu's accessibility
gohabereg 82b69e1
fix(ui): make the block settings menu robust to its own providers
gohabereg 14908df
test(editorjs): group the block settings e2e tests
gohabereg 0d59297
refactor(ui)!: let the block settings plugin own its button
gohabereg 0e3140a
refactor(ui): share the toolbar button styling
gohabereg 053497c
docs: keep the block settings comments to two sentences
gohabereg aef43b1
fix(ci): build type-only workspace dependencies before linting and te…
gohabereg ddaf36f
fix(ui): make the block settings button reachable, dismissable and cheap
gohabereg 8ef0305
docs(openspec): check off the block-settings-ui review follow-ups
gohabereg 8eb68ff
fix(ui): stop one settings provider from taking the whole menu with it
gohabereg baaec46
fix(ui): keep the settings menu pointing at the block it was built for
gohabereg 78e4615
docs(openspec): check off the third-round block-settings-ui follow-ups
gohabereg 4d1950f
fix(ui): keep the block settings target with the button
gohabereg d64a75d
fix(ui): isolate a throwing isActive to the provider that shipped it
gohabereg b477577
docs(openspec): specify and check off the fourth-round block-settings…
gohabereg bb431a4
fix(ui): dismiss the block settings menu from a second Enter
gohabereg 97c8c97
docs(openspec): specify and check off the fifth-round block-settings-…
gohabereg f7cc971
fix(ui): hold the block settings target by id, not by position
gohabereg 4655437
fix(ui): recognise a repeated selection by block and position together
gohabereg 479cc39
feat(ui): tell other plugins which block the UI treats as selected
gohabereg db49275
fix(ui): follow the selection again once nothing is holding the toolbar
gohabereg 4f9b89b
fix(ui): stop a menu rebuild reporting itself as closed and reopened
gohabereg 84af3cb
fix(ui): keep a throwing item handler out of the popover
gohabereg 9d62a54
feat(ui)!: let a settings provider say how long it may take
gohabereg a1e68af
docs(ui): say that block settings must be registered after its host
gohabereg ac6508d
fix(ui)!: leave the tool out of the provider context when it is unknown
gohabereg e79eff9
docs(ui): say when unregistering a settings provider takes effect
gohabereg 839dd52
refactor(default-block-settings-plugin): collect the item titles in o…
gohabereg 7664c08
fix(ui): stop the toolbar's plus button submitting a form
gohabereg d886832
refactor(ui): walk the popover item union instead of a plain record
gohabereg 09670a3
test(ui): reopen the settings menu from the keyboard after the caret …
gohabereg 29139a7
ci(ui): limit the workflow's token permissions and run it in the merg…
gohabereg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| name: Default block settings plugin check | ||
| on: | ||
| pull_request: | ||
| merge_group: | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| issues: write | ||
| actions: read | ||
|
|
||
| jobs: | ||
| package-check: | ||
| uses: ./.github/workflows/package-check.yml | ||
| with: | ||
| package-name: '@editorjs/default-block-settings-plugin' | ||
| working-directory: './packages/plugins/default-block-settings-plugin' | ||
| include-mutations: true | ||
| secrets: | ||
| stryker_dashboard_api_key: ${{ secrets.STRYKER_DASHBOARD_API_KEY }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: UI check | ||
| on: | ||
| pull_request: | ||
| merge_group: | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| issues: write | ||
| actions: read | ||
|
|
||
| jobs: | ||
| package-check: | ||
| uses: ./.github/workflows/package-check.yml | ||
| with: | ||
| package-name: '@editorjs/ui' | ||
| working-directory: './packages/ui' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.