Skip to content

Update deno and o2 - #149

Merged
jayvdb merged 1 commit into
mainfrom
update
Oct 19, 2026
Merged

jayvdb merged 1 commit into
mainfrom
update

Conversation

@jayvdb

@jayvdb jayvdb commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Updates
    • Generated deployment configurations now use OpenObserve 1.1.1.
    • Updated Deno components and the Rust V8 source to newer releases.
    • Improved cron schedule field validation.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 057a638e-95d3-45b4-9d96-fed2995d00ab
📥 Commits

Reviewing files that changed from the base of the PR and between 6d51232 and b63c53c.

⛔ Files ignored due to path filters: 2
  • .mise/mise.lock is excluded by !**/*.lock
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 51
  • .mise/config.mingw.toml
  • .mise/config.toml
  • Cargo.toml
  • config/ast-grep/rules/no-eq-bool-literal.yaml
  • config/deny.toml
  • utilities/cli/src/deployment_types/docker_compose.rs
  • utilities/cli/src/deployment_types/k3s.rs
  • utilities/cli/src/deployment_types/mise.rs
  • utilities/cli/src/schedule.rs
  • verification/local/output/default/compose.yaml
  • verification/local/output/default/k3s.yaml
  • verification/local/output/default/mise.toml
  • verification/local/output/facility-security-scenario/compose.yaml
  • verification/local/output/facility-security-scenario/k3s.yaml
  • verification/local/output/facility-security-scenario/mise.toml
  • verification/local/output/math1-cron/compose.yaml
  • verification/local/output/math1-cron/k3s.yaml
  • verification/local/output/math1-cron/mise.toml
  • verification/local/output/math1-limits/compose.yaml
  • verification/local/output/math1-limits/k3s.yaml
  • verification/local/output/math1-limits/mise.toml
  • verification/local/output/math1-multi/compose.yaml
  • verification/local/output/math1-multi/k3s.yaml
  • verification/local/output/math1-multi/mise.toml
  • verification/local/output/math1/compose.yaml
  • verification/local/output/math1/k3s.yaml
  • verification/local/output/math1/mise.toml
  • verification/local/output/pyo3-math1/compose.yaml
  • verification/local/output/pyo3-math1/k3s.yaml
  • verification/local/output/pyo3-math1/mise.toml
  • verification/local/output/wasi-math1/compose.yaml
  • verification/local/output/wasi-math1/k3s.yaml
  • verification/local/output/wasi-math1/mise.toml
  • verification/published/output/default/compose.yaml
  • verification/published/output/default/k3s.yaml
  • verification/published/output/default/mise.toml
  • verification/published/output/math1-cron/compose.yaml
  • verification/published/output/math1-cron/k3s.yaml
  • verification/published/output/math1-cron/mise.toml
  • verification/published/output/math1-multi/compose.yaml
  • verification/published/output/math1-multi/k3s.yaml
  • verification/published/output/math1-multi/mise.toml
  • verification/published/output/math1/compose.yaml
  • verification/published/output/math1/k3s.yaml
  • verification/published/output/math1/mise.toml
  • verification/published/output/pyo3-math1/compose.yaml
  • verification/published/output/pyo3-math1/k3s.yaml
  • verification/published/output/pyo3-math1/mise.toml
  • verification/published/output/wasi-math1/compose.yaml
  • verification/published/output/wasi-math1/k3s.yaml
  • verification/published/output/wasi-math1/mise.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The pull request updates OpenObserve to version 1.1.1 across deployment configuration and generated manifests. It reorganizes mise task construction, changes scheduled-runner label generation and cron-field validation, and updates workspace dependencies and repository configuration.

Changes: OpenObserve deployments

Layer / File(s) Summary
Mise task assembly
utilities/cli/src/deployment_types/mise.rs
The generator builds collector and hub tasks through service_tasks, resolves runners with scenario_runners, and passes process-compose selection to mise_tools.
OpenObserve image version
.mise/config.toml, utilities/cli/src/deployment_types/docker_compose.rs, utilities/cli/src/deployment_types/k3s.rs, utilities/cli/src/deployment_types/mise.rs
The configured OpenObserve tool and image, and the image references in deployment generators, change to version 1.1.1.
Generated image manifests
verification/{local,published}/output/*/{compose.yaml,k3s.yaml,mise.toml}
Generated local and published Compose, k3s, and mise outputs use OpenObserve 1.1.1.

Scheduled-runner handling

Layer / File(s) Summary
Cron field validation
utilities/cli/src/schedule.rs
standard_field validates range endpoints separately from steps. Steps must be unsigned decimal numbers; endpoints can be numbers, *, or field-specific names.
Ofelia job labels
utilities/cli/src/deployment_types/docker_compose.rs
scheduler_services delegates label creation to job_labels, which trims the cron expression, conditionally prefixes its time zone, and sets the container and no-overlap labels.

Workspace tool versions

Layer / File(s) Summary
Dependency and source versions
.mise/config.mingw.toml, Cargo.toml
The Rusty V8 source URL and Deno workspace dependency requirements are updated. Cargo ignore-list entries and notes also change.

Repository rules

Layer / File(s) Summary
Lint and license configuration
config/ast-grep/rules/no-eq-bool-literal.yaml, config/deny.toml
The ast-grep rule matches equality or inequality expressions containing a boolean literal. The license configuration adds a clarification for libuv-sys-lite.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Suggested reviewers: pierre-tenedero

Merge Risk: ⚪ Minimal · up to b63c5

The reviewed deployment and workspace changes have no identified issue requiring a fix before merge. Normal validation remains appropriate.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately identifies the primary dependency and OpenObserve updates. It is concise and relevant to the main changes.
Docstring Coverage Passed Docstring coverage is 92.31% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 4 files. (47 skipped: 4…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 92.31% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 4 files. (47 skipped: 47 unsupported.)

✨ Finishing Touches: 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 6d51232...b63c53c on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
C# Oct 19, 2026 12:19a.m. Review ↗
C & C++ Oct 19, 2026 12:19a.m. Review ↗
Docker Oct 19, 2026 12:19a.m. Review ↗
Java Oct 19, 2026 12:19a.m. Review ↗
JavaScript Oct 19, 2026 12:19a.m. Review ↗
Python Oct 19, 2026 12:19a.m. Review ↗
Rust Oct 19, 2026 12:19a.m. Review ↗
Secrets Oct 19, 2026 12:19a.m. Review ↗
Code coverage Oct 19, 2026 1:13a.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
100%
78.2%
[▲ up 0.1% from main]
Python -
93.1%
Rust
100%
76.7%
[▲ up 0.1% from main]

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@jayvdb
jayvdb marked this pull request as ready for review October 19, 2026 00:28
@jayvdb
jayvdb merged commit 77e9689 into main Oct 19, 2026
45 checks passed
@jayvdb
jayvdb deleted the update branch October 19, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants