Skip to content

Tooling Prep for Increase in Configurations Supported - #292

Merged
wchilders-nvidia merged 7 commits into
mainfrom
tooling-prep-for-more-configs
Oct 14, 2026
Merged

wchilders-nvidia merged 7 commits into
mainfrom
tooling-prep-for-more-configs

Conversation

@wchilders-nvidia

Copy link
Copy Markdown
Collaborator

In preparation for adding more build types and testing configurations I've prepared these changes:

  • New AGENT.md skill for working with edg-cmakedef.
  • New AGENT.md skill for creating temporary files and working around the container environment efficiently.
  • Disable eccp's injection of automatic template instantiation flags (as part of eccp's processing of the --building_runtime option) for the runtime library build so that configurations that don't support automatic template instantiation can still build the library.
  • Detect and skip tests for which a command-line "mode" flag was required that is not supported by the current configuration (e.g., "--microsoft" implies the config must have MICROSOFT_EXTENSIONS_ALLOWED).
  • And the bigger one: expectation inheritance. Expectations are now inherited in the same way that default outputs are inherited, meaning that expectation updates in the default configuration flow down to child configurations (i.e. if a test is failing in the default, it's expected that it will be failing in the non-default). Thus, non-default configuration expectation files now become deltas against the default configuration. This significantly reduces the number of tests that need to be run on average, because for many many cases, configurations will all agree on the outcome.

Reviewed internally by @nv-cmeerw

@mborland

Copy link
Copy Markdown
Contributor

Since this makes three tooling PRs open (#237 and #246), do you want to merge those first, or pull them into this one? On a cursory look I don't think there are many conflicts between the first two and this one, but they may start to diverge in contents (e.g. pinned docker hashes).

@wchilders-nvidia

Copy link
Copy Markdown
Collaborator Author

I need to look at #237; shouldn't be blocked or a blocker for this one.

#246 I need to get back to but this is arguably more important as without it downstream maintenance is more costly and certain configurations just don't work well with the build system.

@wchilders-nvidia wchilders-nvidia changed the title Toling Prep for Increase in Configurations Supported Tooling Prep for Increase in Configurations Supported Oct 13, 2026

@mborland mborland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've found a couple issues when attempting to build and test everything on ARM64 Mac, so this should help

@wchilders-nvidia
wchilders-nvidia merged commit 034385b into main Oct 14, 2026
17 checks passed
@wchilders-nvidia
wchilders-nvidia deleted the tooling-prep-for-more-configs branch October 14, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants