Repository navigation
Integration tests should run integration tests, not unit tests, too - #140
Merged
Merged
Conversation
The integration Jest config had no path filter, so the unit specs under api/src ran in both the unit and integration suites. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
rtavernaea
approved these changes
Oct 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where unit tests ran twice. In addition to being run with
nx test-unit api, they were run withnx test-integration apibecause the integration jest config just ran all spec files it found. This PR updates the integration jest config to just run tests in the integration folder.You can see the issue in this CI run. The app config unit tests runs here (line 77) and again here (line 888).
Now, the unit tests just run once, as unit tests.
You can check the totals to verify we're not dropping tests:
Before
Unit tests
Integration tests
After
Unit
Integration
372 - 25 = 337