Repository navigation
Shop elements: typed callbacks, a Crypto parameter, and US English in the visible copy - #37
Merged
Merged
Conversation
… the visible copy superherotech.ai vendors the library and runs astro check over it; the cart and product page failed it 13 times (implicit any in the product page's callbacks, and newKey's hand-written Crypto shape). The product page's and product list's visible copy said catalogue and labelled, which the site's US English check refuses. Identifiers (fetchCatalog, the catalog prop, aria-labelledby) are unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
superherotech.ai vendors this library and runs
astro checkover it. The cart and product page failed it 13 times: implicitanyin the product page's array callbacks, andnewKey's hand-written shape forwindow.crypto. The product page's and product list's visible copy also said "catalogue" and "labelled", which the site's US English check refuses. Identifiers (fetchCatalog, thecatalogprop,aria-labelledby) are unchanged.Verified by building superherotech.ai against this branch:
check:types0 errors,check:us-englishclean, and the full site check chain exits 0 with the three new demos' heights measured. Librarynpm run buildandnpm run checkexit 0.🤖 Generated with Claude Code