Refreshed the reason gcc_check leaves RISC-V out - #722
Merged
Conversation
The header explained the exclusion by saying RISC-V "is not regressing" and that adding it would widen the toolchain download. The second half is still true; the first read as though nothing in CI exercised the family at all, which stopped being the case with #717. RISC-V is now the best-covered of the four excluded families rather than the least: regression_test.yml builds both ports and runs 955 tests on them under QEMU -- 475 on RV32 and 480 on RV64, across five build configurations each -- which is more than a compile-and-link check could establish. That is a stronger argument for leaving it out of this workflow than the original, so the sentence now makes it. The download figure is kept and quantified: the two bare-metal toolchains this workflow would have to fetch are about 500 MB apiece. Comment only; no behaviour change. scripts/check_gcc.sh names the same four families but states the exclusion without giving a reason for it, so it needs no matching edit. Assisted-by: Claude Code (Opus 5) <noreply@anthropic.com>
Minimum allowed line rate is |
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of the follow-ups to #717.
gcc_check.yml's header explained why RISC-V sits outside the workflow by saying the family "is not regressing", and that adding it would widen the toolchain download. The second half is still true. The first read as though nothing in CI exercised RISC-V at all, which stopped being the case when #717 merged.RISC-V is now the best-covered of the four excluded families rather than the least.
regression_test.ymlbuilds both ports and runs 955 tests on them under QEMU — 475 on RV32 and 480 on RV64, across five build configurations each — which is more than a compile-and-link check could establish. That is a stronger argument for leaving it out of this workflow than the original one, so the sentence now makes it.The download figure is kept and quantified: the two bare-metal toolchains this workflow would have to fetch are about 500 MB apiece.
Comment only; no behaviour change.
scripts/check_gcc.shnames the same four families at line 54, but states the exclusion without giving a reason for it, so it does not go stale and needs no matching edit.