Skip to content

[2226] Fix imported relationship annotations - #2421

Merged
AxelRICHARD merged 1 commit into
mainfrom
ari/fix/2226
Aug 14, 2026
Merged

[2226] Fix imported relationship annotations#2421
AxelRICHARD merged 1 commit into
mainfrom
ari/fix/2226

Conversation

@AxelRICHARD

@AxelRICHARD AxelRICHARD commented Aug 13, 2026

Copy link
Copy Markdown
Member

Bug: #2226

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gdaniel gdaniel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works as expected, but I assume the PR needs to contribute something the to release note, right?

@AxelRICHARD

Copy link
Copy Markdown
Member Author

The fix works as expected, but I assume the PR needs to contribute something the to release note, right?

I wonder if it is relevant to add this information to the release note, because the change is a bit technical and I am not sure it is useful for end-users to know that. But may be I am wrong.

@gdaniel

gdaniel commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The fix works as expected, but I assume the PR needs to contribute something the to release note, right?

I wonder if it is relevant to add this information to the release note, because the change is a bit technical and I am not sure it is useful for end-users to know that. But may be I am wrong.

I see, indeed, it requires to import a model (which is something end user do), but then the only way I found to check that there is an issue is to run an AQL query in the query view.
This seems too much to put it in the release notes.

Bug: #2226
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
@AxelRICHARD
AxelRICHARD merged commit 00dc414 into main Aug 14, 2026
4 checks passed
@AxelRICHARD
AxelRICHARD deleted the ari/fix/2226 branch August 14, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ElementImpl#getOwnedAnnotation doesn't work as expected

2 participants