[cr checker] refactor - #365
Merged
Merged
Conversation
LittleHuba
reviewed
Jul 24, 2026
Comment on lines
+24
to
+27
| label = native.package_relative_label(src) | ||
| if str(label.workspace_root): | ||
| fail("copyright_checker: srcs must be main-repo labels, got: {}".format(src)) | ||
| return label.package + "/" + label.name if label.package else label.name |
Contributor
There was a problem hiding this comment.
This assumes that a target ends up pointing to files that have a name starting similar as the target. This is often true but not nearly always...
hoe-jo
force-pushed
the
joho_fix_cr_checker_symlinks
branch
2 times, most recently
from
July 30, 2026 14:57
fd80782 to
9a4c684
Compare
- use git based file discovery - change from include to exclude based schema - read file only once (instead of 3 times) - add integration tests
hoe-jo
force-pushed
the
joho_fix_cr_checker_symlinks
branch
from
July 30, 2026 15:50
9a4c684 to
2ad524a
Compare
Coverage ReportCoverage report was generated. Full report can be downloaded from the CI artifacts (expand Artifacts at the bottom of the run). Overall coverage rate: |
LittleHuba
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.