Skip to content

aarch64-linux: link libgcc for outline atomic helpers #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalavrezo-qorix merged 1 commit into from
Jul 17, 2026
Merged

aarch64-linux: link libgcc for outline atomic helpers #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ ferrocene.toolchain(
"-Clink-arg=-lstdc++",
"-Clink-arg=-lm",
"-Clink-arg=-lc",
"-Clink-arg=-lgcc",
Comment on lines 69 to +70

@AlexanderLanin AlexanderLanin Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted review (Claude):

This line is now the only difference between the x86_64 and aarch64 linux flag lists, and its placement is load-bearing. Since CI only validates lockfile consistency and the repo has no build/link test, a future maintainer aligning the toolchains or reordering flags could silently drop it and reintroduce the __aarch64_*_acq_rel link failure with no CI signal. A short comment makes the intent and the ordering constraint durable:

Suggested change
"-Clink-arg=-lc",
"-Clink-arg=-lgcc",
"-Clink-arg=-lc",
# aarch64 GCC uses outline atomics; the __aarch64_*_acq_rel helpers live
# only in static libgcc.a. Must stay last so it follows the C/C++ objects
# that reference them (static archives resolve left-to-right).
"-Clink-arg=-lgcc",

],
miri_sysroot_sha256 = "74f90eabcb34809e44300535016f25eb0cf4a500763c0d18e7f587583b5b9908",
miri_sysroot_strip_prefix = "aarch64-unknown-linux-gnu",
Expand Down
5 changes: 3 additions & 2 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading