Skip to content

chore(docs/cicd): make docs workflow secure - #2986

Draft
AlexanderLanin wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:docs-wf
Draft

chore(docs/cicd): make docs workflow secure#2986
AlexanderLanin wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:docs-wf

Conversation

@AlexanderLanin

Copy link
Copy Markdown
Member

Use new secure docs workflow split, where anything running bazel is treated as untrusted PR context. And that artefact is later picked up by a secure workflow running from main branch (therefore it will not work in this PR, similar to pull_request_target).

As a little byproduct, this makes score repo ready for merge queues! One of the first merge queue capable repos. As everything PR-related is now handled by on-pr workflow!

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@lurtz lurtz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in inc_someip_gateway I used a meta job, which depends on all the required ones and checks their status. Then you only need to configure that one as required in Github / Otterdog. More on that can be found at the pull request.

So far the approach in inc_someip_gateway worked nicely. I never had to touch the .eclipsefdn repo again.

IMHO we should consolidate the patterns being used. IIRC devcontainer, communication and baselibs are using merge queues as well.

@anmittag

Copy link
Copy Markdown
Member

@AlexanderLanin any update on the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants