-
Notifications
You must be signed in to change notification settings - Fork 23
switch link direction between feat and log_arc_int #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RolandJentschETAS
wants to merge
7
commits into
eclipse-score:main
Choose a base branch
from
etas-contrib:improvement_switch_feat_log_int_direction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f5dae6f
switch link direction between feat and log_arc_int
RolandJentschETAS 948cb25
adopt other picture
RolandJentschETAS 82361a9
fix process requirement picture
RolandJentschETAS e74bbc5
change another pictures
RolandJentschETAS f6e0d84
increase req version
RolandJentschETAS 263f4db
increase req version
RolandJentschETAS fc0ee56
remove fillfils from simplified picture beause it is optional now
RolandJentschETAS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 15 additions & 15 deletions
30
process/general_concepts/_assets/score_building_blocks_meta_model.drawio.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
72 changes: 25 additions & 47 deletions
72
...concepts/_assets/score_building_blocks_meta_model_deployment_example.drawio.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
44 changes: 11 additions & 33 deletions
44
...general_concepts/_assets/score_building_blocks_meta_model_simplified.drawio.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are much more images to be updated, please do not forget them, e.g.
https://eclipse-score.github.io/process_description/pr-754/general_concepts/score_building_blocks_concept.html#deployment-example
https://eclipse-score.github.io/process_description/pr-754/general_concepts/score_building_blocks_concept.html#deployment-example
Check also, https://eclipse-score.github.io/process_description/pr-754/general_concepts/score_traceability_concept.html, if there is no left-over
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another one is in https://eclipse-score.github.io/process_description/main/process_areas/architecture_design/guidance/architecture_process_reqs.html#gd_req__arch_build_blocks_corr
and when you are at it, please check if the optional "includes" link from logic_arc_int to logic_arc_int_op makes sense? wouldn't this be added automatically as back-link?
From @RolandJentschETAS : That's independent of the current change. Can we discuss it separate ? For example in the next process meeting, because that shows the current state in docs_as_code meta model.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other 2 pictures are also changed.
The traceability pictures does not contain the logical interface. Therefore they are fine.
The requirement picture is now also changed.
The "logic_arc_int to logic_arc_int_op" is the current state in the metamodel of docs as code. So both are defined independently. At this time when the picture was updated, I added the status quo of the yaml. I propose to discuss this independently from the current PR, because the link direction concept is not clear for me. The link itself is used in the launchmanager for the lifecycle interface.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But fulfills is now optional, must be removed here,
https://eclipse-score.github.io/process_description/main/general_concepts/score_building_blocks_concept.html#hint-for-tool-implementation
that images shows only mandatory links
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no access to this link ... But it is the simplified picture ? Have done it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now?
https://eclipse-score.github.io/process_description/main/general_concepts/score_building_blocks_concept.html#hint-for-tool-implementation