Implementation completion log backend by AdamBienkunski · Pull Request #363 · eclipse-score/logging

AdamBienkunski · 2026-10-16T09:35:35Z

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #328

github-actions · 2026-10-16T09:36:49Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: b44db038-186d-43d9-979c-4fbf8b79559d
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.2.17, but got rules_cc@0.2.25 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
DEBUG: /home/runner/.bazel/external/score_docs_as_code+/docs.bzl:716:14: INFO: ⚠️ DEPRECATED: Passing a Needs inventory through docs(data = [...]) is deprecated!!! Move it to external_needs = [...] instead.
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 17.205s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

rmaddikery

Moving existing files will hamper the exports from internal repo. Please use symlinks if required until we have migrated entirely to score.

AdamBienkunski · 2026-10-20T13:33:31Z

Moving existing files will hamper the exports from internal repo. Please use symlinks if required until we have migrated entirely to score.

Resolved: Changed to symlinks .

rmaddikery · 2026-10-27T08:33:03Z

@@ -0,0 +1,59 @@
+' *******************************************************************************


a puml saying design is not accurate. Also same. Does not require a puml when the code is self explanatory unless we can highlight the constraints, edge cases and limits - can be a follow-up if required.

Dropped from the changed as src is self explanatory

github-actions · 2026-10-27T09:51:52Z

Documentation preview for this pull request is available at:
pr-363: https://eclipse-score.github.io/logging/pr-363/

- Correct the file output text and diagrams after the implementation and set the document safety level to QM. - Correct the recorder diagram and the slot release in the syslog sequence. - Remove the SlotDrainer diagrams that were loaded from score_baselibs by URL. - Link the diagrams into the docs folder by symbolic links. The files stay in score/mw/log/design/backend. Signed-off-by: Adam Bienkunski <Adam.Bienkunski.Ext@qorix.ai>

- Correct the datarouter class, IPC, recorder, shared memory reader and write factory diagrams. - Rewrite the verbose logging, shared memory read and write and the connect to datarouter sequences after the code. - Rewrite the unit diagram so that every sequence participant is a unit, as the architectural_design validation requires. - Reference all datarouter diagrams in the design text, seven were not used before. - Replace the described rate limit by the implemented limits. - Link the diagrams into the docs folder by symbolic links. The files stay in score/mw/log/design/backend. Signed-off-by: Adam Bienkunski <Adam.Bienkunski.Ext@qorix.ai>

- Structure the detailed design as in the module template: description, design decisions with diagram references, constraints per building block, external dependencies, units and interfaces. - Map the architecture interfaces to the source code interfaces and describe boundaries, use and extension. - Drop the syslog backend design page, which only restated the code. The syslog backend is a simple unit like slog, only its sequence diagram stays in the index. Signed-off-by: Adam Bienkunski <Adam.Bienkunski.Ext@qorix.ai>

The syslog backend is not reachable through the //score/mw/log facade, so it was not measured. Signed-off-by: Adam Bienkunski <Adam.Bienkunski.Ext@qorix.ai>

Link the existing tests with RecordProperty("PartiallyVerifies", ...) to the requirements they verify. They were tested but not linked. - comp_req__log__send_to_datarouter: backend log level test and the message client connect and acquire tests. - comp_req__log__inactive_logstream: the recorder log level test. Signed-off-by: Adam Bienkunski <Adam.Bienkunski.Ext@qorix.ai>

Fill in the implementation inspection checklist of the log backend for issue eclipse-score#328 (parent eclipse-score#317). - Add the passed value and the remarks for each checklist item. - Record the findings with their tickets (eclipse-score#318 coverage, eclipse-score#319 requirement traceability, eclipse-score#336 CodeQL) and mark the findings that still need a ticket. - Refer to the generated verification report and the dependency page instead of repeating analysis results. Signed-off-by: Adam Bienkunski <Adam.Bienkunski.Ext@qorix.ai>

AdamBienkunski requested review from 4og, antonkri, arsibo, pawelrutkaq and rmaddikery as code owners October 16, 2026 09:35

github-project-automation Bot added this to LOG - Logging FT Oct 16, 2026

github-project-automation Bot moved this to Backlog in LOG - Logging FT Oct 16, 2026

AdamBienkunski had a problem deploying to workflow-approval October 16, 2026 09:35 — with GitHub Actions Error

AdamBienkunski requested a deployment to workflow-approval October 16, 2026 09:35 — with GitHub Actions Waiting

AdamBienkunski force-pushed the a.b/implementation_completion_log_backend branch from 7cdce9c to 04a27e4 Compare October 16, 2026 09:57

AdamBienkunski requested a deployment to workflow-approval October 16, 2026 09:57 — with GitHub Actions Waiting

AdamBienkunski had a problem deploying to workflow-approval October 16, 2026 09:57 — with GitHub Actions Error

AdamBienkunski force-pushed the a.b/implementation_completion_log_backend branch from 04a27e4 to 2559c3a Compare October 16, 2026 10:07

AdamBienkunski had a problem deploying to workflow-approval October 16, 2026 10:07 — with GitHub Actions Error

AdamBienkunski requested a deployment to workflow-approval October 16, 2026 10:07 — with GitHub Actions Waiting

AdamBienkunski had a problem deploying to workflow-approval October 16, 2026 10:07 — with GitHub Actions Error

rmaddikery requested changes Oct 20, 2026

View reviewed changes

AdamBienkunski force-pushed the a.b/implementation_completion_log_backend branch from 2559c3a to 13b9d92 Compare October 20, 2026 13:32

AdamBienkunski requested a review from hoppe-and-dreams as a code owner October 20, 2026 13:32

AdamBienkunski requested a deployment to workflow-approval October 20, 2026 13:32 — with GitHub Actions Waiting

AdamBienkunski had a problem deploying to workflow-approval October 20, 2026 13:32 — with GitHub Actions Error

rmaddikery reviewed Oct 27, 2026

View reviewed changes

Comment thread scripts/dependency_reports/mw_log_backend.json Outdated

rmaddikery reviewed Oct 27, 2026

View reviewed changes

Comment thread docs/components/mw_log/detailed_design/dependencies.rst Outdated

AdamBienkunski force-pushed the a.b/implementation_completion_log_backend branch from b960c8d to b641066 Compare October 27, 2026 13:17

AdamBienkunski had a problem deploying to workflow-approval October 27, 2026 13:17 — with GitHub Actions Error

AdamBienkunski deployed to workflow-approval October 27, 2026 13:17 — with GitHub Actions Active

AdamBienkunski had a problem deploying to workflow-approval October 27, 2026 13:17 — with GitHub Actions Error

AdamBienkunski requested a review from rmaddikery October 27, 2026 14:12

AdamBienkunski force-pushed the a.b/implementation_completion_log_backend branch from b641066 to 3258eec Compare October 28, 2026 08:20

AdamBienkunski had a problem deploying to workflow-approval October 28, 2026 08:20 — with GitHub Actions Error

AdamBienkunski temporarily deployed to workflow-approval October 28, 2026 08:20 — with GitHub Actions Inactive

AdamBienkunski had a problem deploying to workflow-approval October 28, 2026 08:20 — with GitHub Actions Error

rmaddikery approved these changes Oct 28, 2026

View reviewed changes

github-project-automation Bot moved this from Backlog to On Hold in LOG - Logging FT Oct 28, 2026

AdamBienkunski added 6 commits October 28, 2026 11:14

build(mw/log): add syslog backend to the coverage scope

c84981f

The syslog backend is not reachable through the //score/mw/log facade, so it was not measured. Signed-off-by: Adam Bienkunski <Adam.Bienkunski.Ext@qorix.ai>

AdamBienkunski force-pushed the a.b/implementation_completion_log_backend branch from 3258eec to ec2e740 Compare October 28, 2026 10:14

AdamBienkunski temporarily deployed to workflow-approval October 28, 2026 10:14 — with GitHub Actions Inactive

rmaddikery merged commit 80ac19a into eclipse-score:main Oct 28, 2026
16 checks passed

github-project-automation Bot moved this from On Hold to Done in LOG - Logging FT Oct 28, 2026

Navigation Menu

Repository navigation

Implementation completion log backend - #363

Implementation completion log backend#363
rmaddikery merged 6 commits into
eclipse-score:mainfrom
qorix-group:a.b/implementation_completion_log_backend

AdamBienkunski commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

rmaddikery left a comment

Uh oh!

AdamBienkunski commented Oct 20, 2026

Uh oh!

rmaddikery Oct 27, 2026

Uh oh!

AdamBienkunski Oct 27, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,59 @@
		' *******************************************************************************

Conversation

AdamBienkunski commented Oct 16, 2026

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

rmaddikery left a comment

Choose a reason for hiding this comment

Uh oh!

AdamBienkunski commented Oct 20, 2026

Uh oh!

rmaddikery Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

AdamBienkunski Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Oct 16, 2026 •

edited

Loading