ci: bump coverage workflow refs for --build_tests_only fix - #383
Open
dcalavrezo-qorix wants to merge 1 commit into
Open
ci: bump coverage workflow refs for --build_tests_only fix#383dcalavrezo-qorix wants to merge 1 commit into
dcalavrezo-qorix wants to merge 1 commit into
Conversation
eclipse-score/cicd-workflows#164 (fixed in #165, commit 4c20f0d9): the coverage workflows previously built filtered-out test targets. With wildcard patterns this builds Miri test targets too, whose Miri-sysroot compiles fail under coverage instrumentation (error[E0463]: can't find crate for 'profiler_builtins') once score_toolchains_rust >= 0.9.2 enables Rust coverage. Bumping the refs now, ahead of the toolchain bump (#369), so coverage stays green when it lands.
dcalavrezo-qorix
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
July 29, 2026 11:24
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
MaciejKaszynski
requested changes
Jul 29, 2026
| jobs: | ||
| cpp: | ||
| uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@ea19fcae9aeeb4ac678b750c6c197eaf75414f39 # v0.0.0 | ||
| uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0 # v0.0.0 |
Contributor
There was a problem hiding this comment.
Suggested change
| uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0 # v0.0.0 | |
| uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0 |
Think the comment with the version doesn't make sense to keep. Same thing with the on line 36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the
cpp-coverage.yml/rust-coverage.ymlrefs to cicd-workflows4c20f0d9(eclipse-score/cicd-workflows#165, fixes eclipse-score/cicd-workflows#164).Why: the coverage workflows ran
bazel coverage/bazel testwithout--build_tests_only, so test language/tag filters only affected which tests run — wildcard patterns still built filtered-out tests. That builds the Miri test targets, whose Miri-sysroot compiles fail under coverage instrumentation (error[E0463]: can't find crate for 'profiler_builtins') once score_toolchains_rust ≥ 0.9.2 enables Rust coverage — this is what breaks the C++ Coverage job on #369.Verification: reproduced locally on the #369 toolchain bump — without the fix the coverage invocation aborts (16/19 tests); with
--build_tests_only, exit 0 and 19/19 tests pass. The same bump has also been pushed onto #369 directly to re-run its CI.Merging this first means #369 (and any future toolchain bumps) stay green.