Skip to content

ci: bump coverage workflow refs for --build_tests_only fix - #383

Open
dcalavrezo-qorix wants to merge 1 commit into
mainfrom
dcalavrezo_bump_coverage_workflows
Open

ci: bump coverage workflow refs for --build_tests_only fix#383
dcalavrezo-qorix wants to merge 1 commit into
mainfrom
dcalavrezo_bump_coverage_workflows

Conversation

@dcalavrezo-qorix

Copy link
Copy Markdown
Contributor

Bumps the cpp-coverage.yml / rust-coverage.yml refs to cicd-workflows 4c20f0d9 (eclipse-score/cicd-workflows#165, fixes eclipse-score/cicd-workflows#164).

Why: the coverage workflows ran bazel coverage/bazel test without --build_tests_only, so test language/tag filters only affected which tests run — wildcard patterns still built filtered-out tests. That builds the Miri test targets, whose Miri-sysroot compiles fail under coverage instrumentation (error[E0463]: can't find crate for 'profiler_builtins') once score_toolchains_rust ≥ 0.9.2 enables Rust coverage — this is what breaks the C++ Coverage job on #369.

Verification: reproduced locally on the #369 toolchain bump — without the fix the coverage invocation aborts (16/19 tests); with --build_tests_only, exit 0 and 19/19 tests pass. The same bump has also been pushed onto #369 directly to re-run its CI.

Merging this first means #369 (and any future toolchain bumps) stay green.

eclipse-score/cicd-workflows#164 (fixed in #165, commit 4c20f0d9): the
coverage workflows previously built filtered-out test targets. With
wildcard patterns this builds Miri test targets too, whose
Miri-sysroot compiles fail under coverage instrumentation
(error[E0463]: can't find crate for 'profiler_builtins') once
score_toolchains_rust >= 0.9.2 enables Rust coverage.

Bumping the refs now, ahead of the toolchain bump (#369), so coverage
stays green when it lands.
@github-actions

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 851b0e2a-4a64-4279-bbd7-6a0649fb46c6
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (22 packages loaded, 10 targets configured)

Analyzing: target //:license-check (83 packages loaded, 10 targets configured)

Analyzing: target //:license-check (141 packages loaded, 2200 targets configured)

Analyzing: target //:license-check (156 packages loaded, 5498 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (162 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7434 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10275 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 28.132s, Critical Path: 2.56s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

jobs:
cpp:
uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@ea19fcae9aeeb4ac678b750c6c197eaf75414f39 # v0.0.0
uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0 # v0.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0 # v0.0.0
uses: eclipse-score/cicd-workflows/.github/workflows/cpp-coverage.yml@4c20f0d9509e3a8ac81a7d2d4c493ce2d0cba3c0

Think the comment with the version doesn't make sense to keep. Same thing with the on line 36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

cpp-coverage: bazel coverage builds filtered-out test targets (breaks consumers with Miri/Rust tests)

2 participants