Support deployment_config/working_dir value - #356
Open
TimoSteuerwaldETAS wants to merge 35 commits into
Open
Conversation
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 23, 2026 14:39 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 23, 2026 14:39 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 23, 2026 16:51 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 23, 2026 16:51 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 23, 2026 17:09 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 23, 2026 17:09 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
TimoSteuerwaldETAS
marked this pull request as ready for review
July 23, 2026 17:12
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 24, 2026 06:47 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 24, 2026 06:47 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
| @@ -35,6 +36,8 @@ def run_until_file_deployed( | |||
| :param file_path: path of the file to wait for on the target. | |||
| :param timeout_s: maximum seconds to wait for the file (default: 30). | |||
| :param poll_interval_s: seconds between file-existence checks (default: 0.5). | |||
Contributor
There was a problem hiding this comment.
Maybe update the documentation that poll_interval_s is also used to poll process state
Contributor
There was a problem hiding this comment.
I think now after your latest rebase its no longer used for checking process state.
So now the documentation update is no longer correct
| TEST_STEP("Activate RunTarget Startup") | ||
| { | ||
| score::cpp::stop_token stop_token; | ||
| auto result = client.ActivateRunTarget("Startup").Get(stop_token); |
Contributor
There was a problem hiding this comment.
Launch Manager goes to Startup by default. I think this is redundant.
Looks like we can remove the whole control_daemon_mock from this test
Contributor
Author
There was a problem hiding this comment.
As this test now uses two processes, I would rather stick to control_daemon_mock, because the control_daemon_mock is writing the test_end file. If we drop that process it is unclear when this test is finished, as now the two processes under test need to write the file instead.
Contributor
There was a problem hiding this comment.
Think this is actually causing the error in https://github.com/eclipse-score/lifecycle/actions/runs/30273517385/job/90001693926?pr=356#step:4:1286
Contributor
Author
There was a problem hiding this comment.
Most probably this was related to the missing "is_self_terminating": true option in the application_profile.
It is also passing now in the pipeline: https://github.com/eclipse-score/lifecycle/actions/runs/30453507338/job/90581144811#step:4:4319
Contributor
There was a problem hiding this comment.
Why is the separate Running and Off RunTarget needed for the test?
Can we not just put these processes into Startup and remove the control_daemon_mock altogether?
NicolasFussberger
requested changes
Jul 24, 2026
TimoSteuerwaldETAS
force-pushed
the
feature/honor-deployment-config-working-dir
branch
from
July 24, 2026 09:45
dad60c7 to
71264de
Compare
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 24, 2026 09:45 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
With new version 0.5.0 this is no longer needed.
Two test modifications: - If no working_dir is defined, bin directory is used. - A working dir defined on deployment config level can be overridden on component level
if process does not react on SIGTERM
- add another process - parameterize sandbox_options_process.cpp
Instead of hardcoded path in python.
sandbox_options_process_b was stuck in rare cases, as it never got cpu time and ran into timeout. This was caused by the minimal priority. So priority has been added here. Furthermore process_c added to check default options.
process_c configures neither a component-level working_dir nor one in the defaults section, so the launch manager falls back to bin_dir. Pass the expected default via --working-dir so the test verifies the default working directory path, mirroring how process_a verifies an explicit one. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
TimoSteuerwaldETAS
force-pushed
the
feature/honor-deployment-config-working-dir
branch
from
July 31, 2026 09:59
144bfd4 to
d3e845a
Compare
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 31, 2026 09:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
TimoSteuerwaldETAS
requested a deployment
to
workflow-approval
July 31, 2026 09:59 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Before, this warning appeared: Test execution time ... outside of range for MODERATE tests. Consider setting timeout="short" or size="small".
TimoSteuerwaldETAS
temporarily deployed
to
workflow-approval
July 31, 2026 10:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
TimoSteuerwaldETAS
temporarily deployed
to
workflow-approval
July 31, 2026 10:41 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
MaciejKaszynski
approved these changes
Jul 31, 2026
Contributor
|
New test fails when run in devcontainer @TimoSteuerwaldETAS Can you modify the devcontainer json to make sure this works? |
| "//tests/utils/test_helper", | ||
| "@googletest//:gtest_main", | ||
| ], | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggestion:
Replace
cc_binary(
name = "sandbox_options_process_a",
srcs = [
"sandbox_options_process.cpp",
"verify_sandbox.hpp",
],
deps = [
"//score/launch_manager:control_cc",
"//score/launch_manager:lifecycle_cc",
"//tests/utils/test_helper",
"@googletest//:gtest_main",
],
)
cc_binary(
name = "sandbox_options_process_b",
srcs = [
"sandbox_options_process.cpp",
"verify_sandbox.hpp",
],
deps = [
"//score/launch_manager:control_cc",
"//score/launch_manager:lifecycle_cc",
"//tests/utils/test_helper",
"@googletest//:gtest_main",
],
)
cc_binary(
name = "sandbox_options_process_c",
srcs = [
"sandbox_options_process.cpp",
"verify_sandbox.hpp",
],
deps = [
"//score/launch_manager:control_cc",
"//score/launch_manager:lifecycle_cc",
"//tests/utils/test_helper",
"@googletest//:gtest_main",
],
)with
[
cc_binary(
name = "sandbox_options_process_{}".format(suffix),
srcs = [
"sandbox_options_process.cpp",
"verify_sandbox.hpp",
],
deps = [
"//score/launch_manager:control_cc",
"//score/launch_manager:lifecycle_cc",
"//tests/utils/test_helper",
"@googletest//:gtest_main",
],
)
for suffix in ("a", "b", "c")
]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #343 .
Furthermore the config mapping tests have been fixed and are executed on the pipeline.
A feature integration test has been also added which is testing various options, not only working dir.