Repository navigation
Conversation
- Add mandatory 'id' attribute with pattern validation - Add mandatory 'version' attribute - Make 'tracking' mandatory with eclipse-score/score issue URL pattern - Make 'consequences' mandatory - Constrain 'affects' link to requirement types only - Update tool_req__docs_dec_rec_type to version 2 - Update test file with new mandatory attributes
The version option is already defined in global_base_opts.mandatory_options, causing an overlap error. Remove the duplicate from dec_rec directive.
The metamodel changes for valid_inspected status and graph_checks are already included in PR #943. Removing them from this branch.
These changes (valid_inspected status, graph_checks updates, etc.) are already in PR #943 (align_dr_to_template). Keeping only schema_export specific changes in this branch.
| dec_rec: | ||
| title: Decision Record | ||
| mandatory_options: | ||
| id: ^dec_rec__(Platform|Feature|Component|arch|proc|strat|infra|int)__[0-9a-zA-Z_-]+$ |
There was a problem hiding this comment.
This is a breaking change (e.g. dec_rec__platform__feature_delivery) and we try to avoid this by fixing it first in the other repos for a smooth migration.
Same with the other mandatory options.
There was a problem hiding this comment.
yeah this is only for the score repo I guess. I will prepare a first pr to introduce the new mandatory things
There was a problem hiding this comment.
There was a problem hiding this comment.
It is not just the platform repo. The downstream checks show that it affects multiple repos.
a-zw
changed the title
|
@a-zw please check again with the eclipse-score/score#3349 it should be fine |
| * ``version`` (mandatory) | ||
| * ``consequences`` (mandatory, non-empty) | ||
|
|
||
| A Decision Record shall be able to link to other needs via the optional ``affects`` link. |
There was a problem hiding this comment.
| A Decision Record shall be able to link to other needs via the optional ``affects`` link. | |
| A Decision Record shall be able to link to requirements via the optional ``affects`` link. |
The PR description says "Constrain 'affects' link to requirement types only". If that is true, then this requirement should be adapted accordingly.
Likewise the implementation in metamodel.yaml. Currently, it allows "ANY" and not just requirements.
| GITHUB_TRACKING_LINK_REGEX = ( | ||
| r"(?P<url>https://github\.com/eclipse-score/" | ||
| r"(?P<repo>[^/]+)/(?:issues|pull)/(?P<number>\d+))" | ||
| ) |
There was a problem hiding this comment.
| GITHUB_TRACKING_LINK_REGEX = ( | |
| r"(?P<url>https://github\.com/eclipse-score/" | |
| r"(?P<repo>[^/]+)/(?:issues|pull)/(?P<number>\d+))" | |
| ) | |
| GITHUB_TRACKING_LINK_REGEX = ( | |
| r"(?P<url>https://github\.com/[^/]+/" | |
| r"(?P<repo>[^/]+)/(?:issues|pull)/(?P<number>\d+))" | |
| ) |
Keep it as relaxed as before. Checking the URL for validity happens via the regex in metamodel.yaml and we must not be more restrictive here.
Currently, the problem is that this affects mitigation_issue and probably not intentionally.
| .. test_metadata:: Test Decision Record Type | ||
| :id: test_metadata__dec_rec | ||
| :partially_verifies_list: tool_req__docs_dec_rec_type | ||
| :fully_verifies_list: tool_req__docs_dec_rec_type[version==2] |
There was a problem hiding this comment.
Also verify that a wrong id pattern results in a warning.
| dec_rec: | ||
| title: Decision Record | ||
| mandatory_options: | ||
| id: ^dec_rec__(Platform|Feature|Component|arch|proc|strat|infra|int)__[0-9a-zA-Z_-]+$ |
There was a problem hiding this comment.
It is not just the platform repo. The downstream checks show that it affects multiple repos.
📌 Description
Changes mandatory fields in drs to track their consequences
🚨 Impact Analysis
✅ Checklist
Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information