feat: external_needs attribute - #672
Open
a-zw wants to merge 1 commit into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
a-zw
force-pushed
the
external-needs-attr
branch
5 times, most recently
from
July 29, 2026 08:20
ef2a9ff to
129d2a4
Compare
a-zw
force-pushed
the
external-needs-attr
branch
from
July 31, 2026 15:47
129d2a4 to
3271bf4
Compare
a-zw
marked this pull request as ready for review
July 31, 2026 15:47
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
July 31, 2026 15:47
Comment on lines
+123
to
+127
| For a ``:docs`` they behave the same, | ||
| but for ``:docs_combo`` they do not. | ||
| In a combo build, the ``data`` are treated differently and will include the documentation | ||
| instead of just link the needs online. | ||
| However, ``external_needs`` will always be hyperlinks. |
Comment on lines
+79
to
+83
| - ``external_needs`` (list of bazel labels) | ||
| External ``:needs_json_file`` targets from other modules/repositories | ||
| for referencing their needs. | ||
| Users must specify ``:needs_json_file`` explicitly (not ``:needs_json``). | ||
| Works the same during ``:docs`` and ``:docs_combo``. |
Member
There was a problem hiding this comment.
now that I see this here... let's discuss how to merge that with #677 and the needs-json PR I cannot find at the moment. Since docs_bundle now exposes sourcecode links and needs_json as well. Seems like its a API mess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Add "external_needs" attribute to "docs" Bazel rule.
🚨 Impact Analysis
✅ Checklist